Build the PGO build legs through the global build job template#92296
Merged
jkoritzinsky merged 7 commits intodotnet:mainfrom Sep 21, 2023
Merged
Build the PGO build legs through the global build job template#92296jkoritzinsky merged 7 commits intodotnet:mainfrom
jkoritzinsky merged 7 commits intodotnet:mainfrom
Conversation
…instrument flag instead of setting the property manually.
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsContributes to moving our official builds to using single jobs per runtime + configuration + platform combo. Also, remove the support for PGO instrumentation in the individual build jobs as we're only going to use it through the global build job in this change. Official build at: https://dev.azure.com/dnceng/internal/_build/results?buildId=2271314&view=results
|
…xproj for internal optimization pipelines (we don't use it).
hoyosjs
approved these changes
Sep 20, 2023
Member
hoyosjs
left a comment
hoyosjs
left a comment
There was a problem hiding this comment.
Only question - does it preserve teh package names correctly?
Member
Author
|
Yep! The resulting package names are identical to the prior implementation. |
This was referenced Sep 21, 2023
jakobbotsch
added a commit
to jakobbotsch/runtime
that referenced
this pull request
Oct 9, 2023
Looks like these were missed in dotnet#92296
jakobbotsch
added a commit
that referenced
this pull request
Oct 9, 2023
Looks like these were missed in #92296. This fixes superpmi-collect.
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to moving our official builds to using single jobs per runtime + configuration + platform combo.
Also, remove the support for PGO instrumentation in the individual build jobs as we're only going to use it through the global build job in this change.
Official build at: https://dev.azure.com/dnceng/internal/_build/results?buildId=2271602&view=results