[ci] Install signing plugin after building#8346
Merged
Conversation
A few of the projects in our submodules are configured to sign output files after build: https://github.com/xamarin/xamarin-android-tools/blob/fa3711b7ddac7cea6850a9c1c67beda1996aafc0/src/Xamarin.Android.Tools.AndroidSdk/Xamarin.Android.Tools.AndroidSdk.csproj#L36 https://github.com/xamarin/androidtools/blob/720fd4e7cc2f018c681843210edfc796c97c1dde/Xamarin.AndroidTools/Xamarin.AndroidTools.csproj#L21 We should skip these sign requests during our build as we perform post build signing for all of our shipping artifacts.
Member
Author
jonathanpeppers
approved these changes
Sep 18, 2023
Member
Author
|
This looks to be working as expected, |
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Sep 19, 2023
* main: Localized file check-in by OneLocBuild Task (dotnet#8350) [ci] Install signing plugin after building (dotnet#8346) Bump to dotnet/installer@e1fd7d9649 8.0.100-rc.2.23468.1 (dotnet#8330) Localized file check-in by OneLocBuild Task (dotnet#8341) LEGO: Merge pull request 8344 LEGO: Merge pull request 8343 [ci] Run more MSBuild tests on Linux (dotnet#8335) [Xamarin.Android.Build.Tasks] Improve aapt2 error messages for paths (dotnet#7710) Bump to dotnet/installer@a6b9030047 8.0.100-rc.2.23462.1 (dotnet#8327) Bump to dotnet/installer@476310d94a 8.0.100-rc.2.23456.6 (dotnet#8325)
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Sep 19, 2023
* main: Localized file check-in by OneLocBuild Task (dotnet#8350) [ci] Install signing plugin after building (dotnet#8346) Bump to dotnet/installer@e1fd7d9649 8.0.100-rc.2.23468.1 (dotnet#8330) Localized file check-in by OneLocBuild Task (dotnet#8341) LEGO: Merge pull request 8344
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few of the projects in our submodules are configured to sign output
files after build:
https://github.com/xamarin/xamarin-android-tools/blob/fa3711b7ddac7cea6850a9c1c67beda1996aafc0/src/Xamarin.Android.Tools.AndroidSdk/Xamarin.Android.Tools.AndroidSdk.csproj#L36
https://github.com/xamarin/androidtools/blob/720fd4e7cc2f018c681843210edfc796c97c1dde/Xamarin.AndroidTools/Xamarin.AndroidTools.csproj#L21
We should skip these sign requests during our build as we perform post
build signing for all of our shipping artifacts.