MAUI project with non-ASCII project name cannot release to my Android phone#7710
Merged
jonpryor merged 8 commits intodotnet:mainfrom Sep 15, 2023
Merged
MAUI project with non-ASCII project name cannot release to my Android phone#7710jonpryor merged 8 commits intodotnet:mainfrom
jonpryor merged 8 commits intodotnet:mainfrom
Conversation
dellis1972
force-pushed
the
WI1714603
branch
2 times, most recently
from
43c1333 to
fd4faf5
Compare
dellis1972
force-pushed
the
WI1714603
branch
3 times, most recently
from
fa74273 to
519d497
Compare
dellis1972
force-pushed
the
WI1714603
branch
3 times, most recently
from
151a91d to
0ee0602
Compare
dellis1972
force-pushed
the
WI1714603
branch
2 times, most recently
from
a98eac2 to
1dcffb3
Compare
jpobst
reviewed
Mar 15, 2023
src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/AotTests.cs
Outdated
Show resolved
Hide resolved
dellis1972
force-pushed
the
WI1714603
branch
2 times, most recently
from
c43c162 to
e2396eb
Compare
dellis1972
force-pushed
the
WI1714603
branch
2 times, most recently
from
8b1f657 to
b5d6f8f
Compare
dellis1972
force-pushed
the
WI1714603
branch
3 times, most recently
from
7d898d2 to
e3cacb1
Compare
dellis1972
force-pushed
the
WI1714603
branch
3 times, most recently
from
a5ec2f1 to
0b53dc8
Compare
dellis1972
force-pushed
the
WI1714603
branch
4 times, most recently
from
5aaff27 to
f1c8765
Compare
dellis1972
force-pushed
the
WI1714603
branch
from
def258c to
105ea01
Compare
dellis1972
force-pushed
the
WI1714603
branch
from
d734f2c to
8645de7
Compare
dellis1972
requested review from
jonathanpeppers and
jonpryor
as code owners
dellis1972
force-pushed
the
WI1714603
branch
from
8645de7 to
06b658f
Compare
jonathanpeppers
approved these changes
Sep 6, 2023
Member
jonathanpeppers
left a comment
jonathanpeppers
left a comment
There was a problem hiding this comment.
The overall code changes look good. 👍
dellis1972
force-pushed
the
WI1714603
branch
from
14b6082 to
97caad8
Compare
jonpryor
reviewed
Sep 7, 2023
jonpryor
reviewed
Sep 7, 2023
… phone Context https://i.azdo.io/1714603 Context https://issuetracker.google.com/issues/188679588 There is a known issue with `aapt2`, `AndroidAsset` and non-ASCII paths/project names. `aapt2` has a bug where it cannot correctly traverse a directory which contains non-ASCII characters. We curently have no way to work around this issue. So the PR adds some more detail to the specific error message which `aapt2` raises in these cases. It suggests the user check their paths to make sure it does not contain non-ASCII characters. We also add some unit tests to cover this senario.
dellis1972
force-pushed
the
WI1714603
branch
from
08a8a26 to
5c1347f
Compare
jonpryor
reviewed
Sep 13, 2023
| proj.SetAndroidSupportedAbis ("armeabi-v7a", "arm64-v8a", "x86", "x86_64"); | ||
| using (var builder = CreateApkBuilder (Path.Combine (rootPath, proj.ProjectName))){ | ||
| builder.ThrowOnBuildFailure = false; | ||
| Assert.AreEqual (expectedResult, builder.Build (proj), "Build should have succeeded."); |
Contributor
There was a problem hiding this comment.
Should this also verify the build error?
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Sep 18, 2023
* main: LEGO: Merge pull request 8343 [ci] Run more MSBuild tests on Linux (dotnet#8335) [Xamarin.Android.Build.Tasks] Improve aapt2 error messages for paths (dotnet#7710)
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Sep 19, 2023
* main: Localized file check-in by OneLocBuild Task (dotnet#8350) [ci] Install signing plugin after building (dotnet#8346) Bump to dotnet/installer@e1fd7d9649 8.0.100-rc.2.23468.1 (dotnet#8330) Localized file check-in by OneLocBuild Task (dotnet#8341) LEGO: Merge pull request 8344 LEGO: Merge pull request 8343 [ci] Run more MSBuild tests on Linux (dotnet#8335) [Xamarin.Android.Build.Tasks] Improve aapt2 error messages for paths (dotnet#7710) Bump to dotnet/installer@a6b9030047 8.0.100-rc.2.23462.1 (dotnet#8327) Bump to dotnet/installer@476310d94a 8.0.100-rc.2.23456.6 (dotnet#8325)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context https://i.azdo.io/1714603
Context https://issuetracker.google.com/issues/188679588
There is a known issue with
aapt2,AndroidAssetand non-ASCII paths/project names.aapt2has a bug where it cannot correctly traverse a directory which contains non-ASCIIcharacters. We curently have no way to work around this issue.
So the PR adds some more detail to the specific error message which
aapt2raises inthese cases. It suggests the user check their paths to make sure it does not contain
non-ASCII characters.
We also add some unit tests to cover this senario.