[master] compose: use updated makefile#748
Merged
thaJeztah merged 1 commit intodocker:masterfrom Aug 26, 2022
Merged
Conversation
Member
thaJeztah
commented
Aug 23, 2022
- testing Makefile: mutualize local and Dockerfile build opts compose#9776
thaJeztah
commented
Aug 23, 2022
thaJeztah
commented
Aug 23, 2022
thaJeztah
commented
Aug 23, 2022
cdfb3b5 to
56ef277
Compare
56ef277 to
7f3ce09
Compare
Member
Author
|
Hm... what did I mess up? Previous test before the compose PR was merged worked; wondering what changed; |
Member
Author
|
OOOOH, 🤦 they didn't merge it; I thought it was in v2.10.1; docker/compose#9776 |
7f3ce09 to
1991d4b
Compare
Member
Author
|
Trying again, this time with #754 😄 |
crazy-max
previously approved these changes
Aug 26, 2022
compose v2.10.1 comes with an updated Makefile, allowing us again to use the makefile for building as part of the rpm/deb scripts. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
1991d4b to
b0621bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.