Skip to content

[do not merge] vendor: github.com/spf13/cobra v1.7.0#4186

Closed
thaJeztah wants to merge 2 commits intodocker:masterfrom
thaJeztah:bump_cobra_split_temporary
Closed

[do not merge] vendor: github.com/spf13/cobra v1.7.0#4186
thaJeztah wants to merge 2 commits intodocker:masterfrom
thaJeztah:bump_cobra_split_temporary

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

splitting #4173 into 2 separate commits, to make the diff easier to review (other PR includes "copyright year" updates)

full diff: spf13/cobra@v1.6.1...567ea8e

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
release notes: https://github.com/spf13/cobra/releases/tag/v1.7.0

Features

- Allow to preserve ordering of completions in bash, zsh, pwsh, & fish
- Add support for PowerShell 7.2+ in completions
- Allow sourcing zsh completion script

Bug fixes

- Don't remove flag values that match sub-command name
- Fix powershell completions not returning single word
- Remove masked template import variable name
- Correctly detect completions with dash in argument

Testing & CI/CD

- Deprecate Go 1.15 in CI
- Deprecate Go 1.16 in CI
- Add testing for Go 1.20 in CI
- Add tests to illustrate unknown flag bug

Maintenance

- Update main image to better handle dark backgrounds
- Fix stale.yaml mispellings
- Remove stale bot from GitHub actions
- Add makefile target for installing dependencies
- Add Sia to projects using Cobra
- Add Vitess and Arewefastyet to projects using cobra
- Fixup for Kubescape github org
- Fix route for GitHub workflows badge
- Fixup for GoDoc style documentation
- Various bash scripting improvements for completion
- Add Constellation to projects using Cobra

Documentation

- Add documentation about disabling completion descriptions
- Improve MarkFlagsMutuallyExclusive example in user guide
- Update shell_completions.md
- Update copywrite year
- Document suggested layout of subcommands
- Replace deprecated ExactValidArgs with MatchAll in doc

full diff: spf13/cobra@v1.6.1...v1.7.0

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #4186 (e0f1574) into master (fff5a31) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4186   +/-   ##
=======================================
  Coverage   59.03%   59.03%           
=======================================
  Files         288      288           
  Lines       24776    24776           
=======================================
  Hits        14627    14627           
  Misses       9265     9265           
  Partials      884      884           

@thaJeztah thaJeztah closed this Apr 11, 2023
@thaJeztah thaJeztah deleted the bump_cobra_split_temporary branch April 11, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants