vendor: github.com/spf13/cobra v1.7.0#4173
Merged
thaJeztah merged 1 commit intodocker:masterfrom Apr 12, 2023
Merged
Conversation
release notes: https://github.com/spf13/cobra/releases/tag/v1.7.0 Features - Allow to preserve ordering of completions in bash, zsh, pwsh, & fish - Add support for PowerShell 7.2+ in completions - Allow sourcing zsh completion script Bug fixes - Don't remove flag values that match sub-command name - Fix powershell completions not returning single word - Remove masked template import variable name - Correctly detect completions with dash in argument Testing & CI/CD - Deprecate Go 1.15 in CI - Deprecate Go 1.16 in CI - Add testing for Go 1.20 in CI - Add tests to illustrate unknown flag bug Maintenance - Update main image to better handle dark backgrounds - Fix stale.yaml mispellings - Remove stale bot from GitHub actions - Add makefile target for installing dependencies - Add Sia to projects using Cobra - Add Vitess and Arewefastyet to projects using cobra - Fixup for Kubescape github org - Fix route for GitHub workflows badge - Fixup for GoDoc style documentation - Various bash scripting improvements for completion - Add Constellation to projects using Cobra Documentation - Add documentation about disabling completion descriptions - Improve MarkFlagsMutuallyExclusive example in user guide - Update shell_completions.md - Update copywrite year - Document suggested layout of subcommands - Replace deprecated ExactValidArgs with MatchAll in doc full diff: spf13/cobra@v1.6.1...v1.7.0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4173 +/- ##
=======================================
Coverage 59.03% 59.03%
=======================================
Files 288 288
Lines 24776 24776
=======================================
Hits 14627 14627
Misses 9265 9265
Partials 884 884 |
Member
|
I don't see anything that could cripple cli perfs in this changelog, but as there's been some ongoing work on this area I'm wondering if we should systematically validate any upgrade of spf13/cobra with a proper benchmark 🤔 WDYT? |
Member
Author
|
Yeah, we could run @crazy-max's script to double-check. I think the performance regression we had was mostly on our side (not specifically cobra). I did have a look at the changes, and didn't see anything immediately concerning. The diff is a bit "larger" due to the copyright changes included (most changed files are because of that, and some linting fixes); to make the diff easier to read, I just pushed a quick PR that splits the diff into two commits (only to help reviewing, shouldn't be merged); |
Member
|
You can try with https://github.com/crazy-max/docker-cli-bench edit: added your branch @thaJeztah crazy-max/docker-cli-bench@58b6e71 |
Member
LGTM looking at the bench results 👍
|
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
docker-20.10.12 |
25.9 ± 2.6 | 22.3 | 28.7 | 2.52 ± 0.34 |
docker-20.10.17 |
27.0 ± 2.5 | 23.5 | 29.8 | 2.63 ± 0.34 |
docker-20.10.23 |
16.7 ± 1.6 | 15.5 | 19.5 | 1.62 ± 0.21 |
docker-23.0.1 |
355.0 ± 8.8 | 341.3 | 361.9 | 34.55 ± 3.18 |
docker-23.0.3 |
362.5 ± 2.9 | 360.2 | 367.4 | 35.28 ± 3.14 |
docker-24.0.0-beta.1 |
10.3 ± 0.9 | 9.5 | 11.6 | 1.00 |
docker-dev-fix-perf-reg |
11.4 ± 1.5 | 9.6 | 13.4 | 1.11 ± 0.18 |
docker-dev-fix-racy-help |
11.0 ± 0.7 | 10.1 | 11.9 | 1.07 ± 0.12 |
docker-dev-pr-3419-a4b6fe1 |
21.2 ± 2.2 | 18.8 | 24.1 | 2.07 ± 0.28 |
docker-dev-pr-4114-f5d698a |
347.9 ± 8.7 | 334.6 | 357.7 | 33.86 ± 3.12 |
docker-dev-pr-4173-c25b8f8 |
10.3 ± 0.9 | 9.3 | 11.4 | 1.00 ± 0.13 |
crazy-max
approved these changes
Apr 11, 2023
rumpl
approved these changes
Apr 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
release notes: https://github.com/spf13/cobra/releases/tag/v1.7.0
Features
Bug fixes
Testing & CI/CD
Maintenance
Documentation
full diff: spf13/cobra@v1.6.1...v1.7.0
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)