Skip to content

UFAL/Configuration for DOI#976

Closed
Paurikova2 wants to merge 1 commit intodtq-devfrom
ufal/allowing-doi-in-config
Closed

UFAL/Configuration for DOI#976
Paurikova2 wants to merge 1 commit intodtq-devfrom
ufal/allowing-doi-in-config

Conversation

@Paurikova2
Copy link
Collaborator

@Paurikova2 Paurikova2 commented May 26, 2025

Phases MP MM MB MR JM Total
ETA 0 0 0 0 0 0
Developing 0 0 0 0 0 0
Review 0 0 0 0 0 0
Total - - - - - 0
ETA est. 0
ETA cust. - - - - - 0

Problem description

The DOI identifier is not allowed by configs. Allow it based on https://wiki.lyrasis.org/display/DSDOC7x/DOI+Digital+Object+Identifier#DOIDigitalObjectIdentifier-CommandLineInterface. Create cron job for registration and metadata creating.
For it to work, changes from this PR also need to be applied: #975

Summary by CodeRabbit

  • Chores
    • Enabled processing of DOI-related events in the default event dispatcher configuration.
    • Activated the DOI identifier provider in the system configuration.

@coderabbitai
Copy link

coderabbitai bot commented May 26, 2025

Walkthrough

The changes update configuration files to activate the DOI identifier provider and include the DOI consumer in the event dispatcher’s default consumers. This enables processing of DOI-related events and ensures the DOI identifier provider bean is active in the application context.

Changes

File(s) Change Summary
dspace/config/clarin-dspace.cfg Added "doi" to the event.dispatcher.default.consumers list, enabling DOI event processing.
dspace/config/spring/api/identifier-service.xml Uncommented and activated the DOIIdentifierProvider bean; minor comment formatting adjustment.

Poem

In the warren of configs, a tweak for DOI,
Now events hop along, none shall pass by.
With beans awakened, identifiers sing,
Springtime in code—let the DOIs spring!
🥕✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 793a73c and d9094b9.

📒 Files selected for processing (2)
  • dspace/config/clarin-dspace.cfg (1 hunks)
  • dspace/config/spring/api/identifier-service.xml (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: dspace-dependencies / docker-build (linux/amd64, ubuntu-latest, true)
  • GitHub Check: Run Unit Tests
  • GitHub Check: Run Integration Tests
🔇 Additional comments (3)
dspace/config/clarin-dspace.cfg (1)

234-234: LGTM! DOI consumer properly added to event dispatcher.

The addition of "doi" to the default consumers list enables DOI-related events to be processed alongside other consumers. This change is consistent with the DOI configuration already present in the file and aligns with the PR objective to enable DOI support.

dspace/config/spring/api/identifier-service.xml (2)

59-59: Minor formatting improvement.

The comment formatting fix improves code readability.


60-67: DOI identifier provider correctly enabled.

The VersionedDOIIdentifierProvider bean is properly configured with necessary dependencies (configurationService and DOIConnector). This provider is appropriate for DSpace installations with item versioning enabled, which aligns with the existing versioned handle provider configuration.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Paurikova2 Paurikova2 linked an issue May 26, 2025 that may be closed by this pull request
@milanmajchrak
Copy link
Collaborator

Just keep the required configuration in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New version of the Item has the same DOI

2 participants