UFAL/Health report item summary#1147
Merged
milanmajchrak merged 1 commit intodtq-devfrom Nov 18, 2025
Merged
Conversation
* used not exists instead of not null| * used id of dspace object
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes a database query in the health report item summary by replacing a NOT IN subquery with a more efficient NOT EXISTS pattern and using the object ID instead of the full object reference for comparison.
Key Changes:
- Replaced
NOT INwithNOT EXISTSsubquery pattern for better query performance - Changed comparison from
res.dSpaceObjecttores.dSpaceObject.idfor direct ID comparison
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
milanmajchrak
approved these changes
Nov 18, 2025
vidiecan
approved these changes
Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
used not exists instead of not null|
used id of dspace object
Cherry-picked from VSB-TUO to improve the performance of the health report item summary.