VSB-TUO/Health report item summary#1133
Merged
milanmajchrak merged 2 commits intocustomer/vsb-tuofrom Oct 30, 2025
Merged
Conversation
Paurikova2
changed the title
milanmajchrak
approved these changes
Oct 30, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the countWithNoPolicy query in BitstreamDAOImpl to use a NOT EXISTS clause instead of NOT IN for better performance and readability.
Key Changes:
- Replaced
NOT INsubquery withNOT EXISTScorrelated subquery - Improved query formatting and readability with multi-line string concatenation
- Added proper join condition using
res.dSpaceObject.id = bit.idinstead of selectingres.dSpaceObject
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Paurikova2
added a commit
that referenced
this pull request
Nov 5, 2025
* used not exists instead of not null| * used id of dspace object
milanmajchrak
pushed a commit
that referenced
this pull request
Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem description
There was a SELECT statement that used NOT NULL. In that case, the left side returned 555,375 results and the right side 643,715 results, so there were more than 357 billion comparisons.