Revert "fix(1805): dry run fails when table/view/assertion already does not exists"#1834
Merged
Revert "fix(1805): dry run fails when table/view/assertion already does not exists"#1834
Conversation
… exsist …" This reverts commit 4d20929.
Tuseeq1
approved these changes
Sep 9, 2024
Tuseeq1
added a commit
that referenced
this pull request
Sep 13, 2024
* MOSSC1: Build and publish with GCB * Update both packages * Revert "fix: dry run fails when table/view/assertion already does not exsist …" (#1834) This reverts commit 4d20929. * Fixes and explanations * Fixes and explanations * Cloudbuild.yaml for old trigger * Cloudbuild * resolve comments. * Convert cloudbuild to bash scripts * newline * GH PR assign to dataform-co/dataform-reviewers * Local test cap * New line * Script fix * script fix * rename test scripts --------- Co-authored-by: Elias Kassell <elias@dataform.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #1806
This causes
//tests/integration:bigquery.spec, instead we needdryRunshould be passed toassertTasks, and only skipselect sum(1)then