Conversation
Ekrekr
left a comment
Ekrekr
left a comment
There was a problem hiding this comment.
This fails tests currently, I think you can have multiple options for which cloud build file to use for testing. That would prevent merging this and having tests broken until it is updated
| resolved "https://us-npm.pkg.dev/artifact-foundry-prod/ah-3p-staging-npm/@babel/code-frame/-/code-frame-7.8.3.tgz" | ||
| integrity "sha1-M+JZA9dIEYFTThLsCiXxa2/PQZ4=sha512-a9gxpmdXtZEInkCSHUJDLHZVBgb1QS0jhss4cPP93EW7s+uC5bikET2twEF3KV+7rDblJcmNvTR7VJejqd2C2g== sha512-a9gxpmdXtZEInkCSHUJDLHZVBgb1QS0jhss4cPP93EW7s+uC5bikET2twEF3KV+7rDblJcmNvTR7VJejqd2C2g==" |
There was a problem hiding this comment.
What is the process for installing new packages now, or bumping versions? Does yarn install x@1 still work?
There was a problem hiding this comment.
ideally.
bazel run @nodejs//:yarn config set registry https://us-npm.pkg.dev/artifact-foundry-prod/ah-3p-staging-npm/
bazel run @nodejs//:yarn add x@1.
There was a problem hiding this comment.
That's not terrible.
It would be good to document this, right? https://github.com/dataform-co/dataform/blob/main/contributing.md#add-new-npm-dependencies
2 participants
Summary:
In order to use GCB for all building and publishing needs, new
cloudbuild-*.yamlfiles are added that will be used by triggers in our GCP project. Moreover,yarn.lockfile has been updated to pull dependencies from google's verified sources.Changes:
yarn.lockto change dependencies location to google npm package manager.cloudbuild.yamlfile and replaced with following new build files.cloudbuild-publish.yaml. This build will get triggered when new code is pushed to main such that theversion.bzlfile has been updated i-e: a new version is ready for release. This will build and published to updated packages to NPM.cloudbuild-test.yaml. This will be trigger when a new PR is created or code is pushed to main such that the version.bzl is not changed. This will run tests.cloudbuild-version.yaml. This will be triggered on 1st of every month. This will update the version number inversion.bzlin a new branch and create a PR to main.scripts/update_version. The previous step uses this script to update the patch version number.