Add legal_entity fields to StripeConnectAccount#588
Merged
Conversation
This was referenced Dec 21, 2016
joshsmith
force-pushed
the
add-legal-entity-fields-to-stripe-connect-account
branch
from
a0ceb90 to
8115289
Compare
joshsmith
approved these changes
Dec 21, 2016
joshsmith
deleted the
add-legal-entity-fields-to-stripe-connect-account
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR adds a migration with all of the legal entity fields added to the
stripe_connect_accountstable.In order to make this as simple as possible, I also did a rewrite of the associated adapter, so it now uses a new, more explicit, mapping-based approach. This provides a nice overview of how each field is mapped and hopefully facilitates future mapping changes.
Considering the amount of fields we have right now, it may be possible we end up needing mapping in a different direction, so the new system will help with that as well, although I did not develop it with that in mind.
References
Fixes #587