Add status fields to stripe connect account #585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@begedin you might be right. |
Contributor
|
@begedin is this currently reviewable or not yet? |
Contributor
Author
|
@joshsmith It should be, feel free to review. |
Contributor
Author
|
@joshsmith I made the switch to the view, as we discussed. #588 needs to be merged and this slightly modified before we can merge it. |
joshsmith
force-pushed
the
579-add-status-fields
branch
from
fddd811 to
8b8fac4
Compare
joshsmith
force-pushed
the
579-add-status-fields
branch
from
8b8fac4 to
92608c6
Compare
joshsmith
approved these changes
Dec 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR adds the four status fields required for fully setting up a stripe connect account.
A work in progress
References
Fixes #579
Notes
The issue states the following for the
personal_id_number_statusfield:requiredlegal_entity.personal_id_number_providedisfalseverification[fields_needed]contains"legal_entity.personal_id_number"verifyinglegal_entity.personal_id_number_providedistrueverification[fields_needed]contains"legal_entity.verification. personal_id_number"verifiedlegal_entity.personal_id_number_providedistruelegal_entity[verification][status]is"pending"This seems strange to me.
Wouldn't the proper condition for
verifyingandverifiedbe something like:verifyinglegal_entity.personal_id_number_providedistrueverification[status]is equal to"pending"verifiedlegal_entity.personal_id_number_providedistrueverification[fields_needed]does not contain"legal_entity.personal_id_number"