896 folder plus file pagination #903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 41702ac.
tcnichol
approved these changes
Feb 2, 2024
Contributor
tcnichol
left a comment
tcnichol
left a comment
There was a problem hiding this comment.
I tested this for non-public datasets. It looks good and works, so I am marking approved.
longshuicy
added a commit
that referenced
this pull request
Feb 6, 2024
* might work * working now * model working now * everything in dataset should work * facet skip limit works * wire pagination to explore page * set model; but can't make id work * user has quirks but kinda works * files pagination * revert dataset.tsx change * file not working * need to replace pyObjectId with pydanticObjectId otherwise the objectId can't be json serialized * update to pydanticObjectId * clean up files component * file and datasets should all work now * toggle user works * fix everything with search user * fix group pagination * fix share group * file pagination should only stay in file page * apikey pagination works * metadata defintion refactored * listener jobs not quite working * listener pagination finished * rewrite sort * replace all pyObjectId to pydanticObjectId * extraction history hooked with backend * fix pytest * sorting works * black * black formatter * fix bug * more metadata bugs * update pages * moving to config * metadata plural to singualar * summarize page metadata into a function * use metadata construction function in dataset * upgrade black to latest version see if it fixes the linting issue * Revert "upgrade black to latest version see if it fixes the linting issue" This reverts commit aa660df. * pin black action version to 23.3.0 to match pipfile * black * 896 folder plus file pagination (#903) * fix folder pagination * fix metadata pagination bug * fix another one * flipping logic clean up * frontend pagination is impossible... * Revert "frontend pagination is impossible..." This reverts commit 41702ac. * the view is working * redux for folder and files * listing works * fix query bug * nested folder correct now * allow fancy sorting * fix subfolder and file pagination issue * remove outdated redux action and states * black * adjust file folder per page * 901 pagination update with public datasets (#907) * fix folder pagination * fix metadata pagination bug * fix another one * flipping logic clean up * frontend pagination is impossible... * Revert "frontend pagination is impossible..." This reverts commit 41702ac. * the view is working * redux for folder and files * listing works * fix query bug * nested folder correct now * allow fancy sorting * fix subfolder and file pagination issue * remove outdated redux action and states * black * public endpoint pagination conversion * public folder paths not working * fix public folder path * black * use utility function to construct page metadata * small fix, call to a method that did not exist for public datasets --------- Co-authored-by: toddn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR features:
/dataset/{id}/folders_and_filesto list all the folders and files; with folders listed first and sorted by created dateTo Test:
To Do:
I haven't touch anything related to public datasets. Will address in another issue: #901