-
Notifications
You must be signed in to change notification settings - Fork 6
872 refactoring pagination #894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Id can't be json serialized
Closed
longshuicy
commented
Jan 29, 2024
longshuicy
commented
Jan 29, 2024
ddey2
reviewed
Feb 2, 2024
…ssue" This reverts commit aa660df.
* fix folder pagination * fix metadata pagination bug * fix another one * flipping logic clean up * frontend pagination is impossible... * Revert "frontend pagination is impossible..." This reverts commit 41702ac. * the view is working * redux for folder and files * listing works * fix query bug * nested folder correct now * allow fancy sorting * fix subfolder and file pagination issue * remove outdated redux action and states * black * adjust file folder per page
* fix folder pagination * fix metadata pagination bug * fix another one * flipping logic clean up * frontend pagination is impossible... * Revert "frontend pagination is impossible..." This reverts commit 41702ac. * the view is working * redux for folder and files * listing works * fix query bug * nested folder correct now * allow fancy sorting * fix subfolder and file pagination issue * remove outdated redux action and states * black * public endpoint pagination conversion * public folder paths not working * fix public folder path * black * use utility function to construct page metadata
tcnichol
approved these changes
Feb 5, 2024
Contributor
tcnichol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked pagination with files and folders, public and not public. Looks good, marking approved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has below features:
metadataanddata.To Test
Try below frontend view:

- Datasets view
/- File view

/datasets/{datasetId}- List and search extractors --> Analysis tab under

/datasets/{datasetId}- List and search users

/manage-users- List and search groups

/groups- List and search metadata

/metadata-definitions- Extractors and Extractor History pagination

/extractions- APIKey pagination

/apikeysTODOs