Skip to content

Conversation

@longshuicy
Copy link
Member

@longshuicy longshuicy commented Mar 13, 2023

Ready to be reviewed

What's working:

  • getting dataset and file roles at routes level and store in redux
  • on dataset and file page have roleChip component to show the current role of user
  • 403 page
  • AuthWrapper pattern that takes in the current role + allowed roles + component and decide if to show or not to show the component

What's not working yet
- 404 page instead of 403 page because if user has no roles, the query to /role endpoints will throw 404
- File roles are not working on the backend. Getting 500 errors

  • Need to do the same AuthWrapper pattern to more complicated components (metadata, extractors etc). Maybe another task?

@longshuicy longshuicy linked an issue Mar 13, 2023 that may be closed by this pull request
@longshuicy longshuicy requested review from arunapa and tcnichol March 14, 2023 22:23
@longshuicy longshuicy marked this pull request as ready for review March 14, 2023 22:23
@longshuicy longshuicy requested a review from max-zilla as a code owner March 14, 2023 22:23
@max-zilla max-zilla merged commit b68a525 into main Mar 15, 2023
@max-zilla max-zilla deleted the 351-add-authorization-to-ui branch March 15, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add authorization to UI

4 participants