add metadata auth framework. #359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Need to be updated after #354 gets merged |
Contributor
Author
|
Will update once that is merged. |
# Conflicts: # backend/app/deps/authorization_deps.py # backend/app/routers/authorization.py
max-zilla
reviewed
Mar 7, 2023
Contributor
max-zilla
left a comment
max-zilla
left a comment
There was a problem hiding this comment.
a couple comments for clarification
backend/app/routers/authorization.py
Outdated
| async def get_metadata_role( | ||
| metadata_id: str, | ||
| current_user=Depends(get_current_username), | ||
| role: RoleType = Depends(get_role_by_file), |
Contributor
There was a problem hiding this comment.
should this be get_role_by_metadata?
| async for md in db["metadata"].find(query): | ||
| md_out = MetadataOut.from_mongo(md) | ||
| resource_type = md_out.resource.collection | ||
| resource_id = md_out.resource.resource_id |
max-zilla
approved these changes
Mar 8, 2023
longshuicy
pushed a commit
that referenced
this pull request
Mar 13, 2023
* adding wrapper for metadata authorization * formatting * using pyobjectid not str * merge,adding for metadata * formatting * small fixes based on max's comments * formatting
max-zilla
added a commit
that referenced
this pull request
Mar 15, 2023
* tests * skeleton code * codegen * connect to get role endpoint in redux * add role chip * add to file; but need to investigate why backend file doesn't work * implement some basic role * break action menu into owner, editor, upload * add 403 page * still falls to not found * add metadata auth framework. (#359) * adding wrapper for metadata authorization * formatting * using pyobjectid not str * merge,adding for metadata * formatting * small fixes based on max's comments * formatting * adding restart unless stopped for this container (#341) * Implement FileAuthorization dependency (#385) * add FileAuthorization dependency * formatting * adjust permissions to uploader for a couple routes --------- Co-authored-by: toddn <[email protected]> * codgen * write auth wrapper pattern * fix file role * temp fix for 403 * add protection on file menu * add protection on file * remove extraneous role filter on user roles --------- Co-authored-by: Todd Nicholson <[email protected]> Co-authored-by: Max Burnette <[email protected]> Co-authored-by: toddn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modeled after Max's pull request. Checks authorization of metadata based on either file or dataset.