-
Notifications
You must be signed in to change notification settings - Fork 6
253 implement extractor filtering by category #264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lmarini
merged 12 commits into
252-use-rjsf-to-dynamically-generate-extractor-parameter-forms
from
253-implement-extractor-filtering-by-category
Jan 13, 2023
Merged
253 implement extractor filtering by category #264
lmarini
merged 12 commits into
252-use-rjsf-to-dynamically-generate-extractor-parameter-forms
from
253-implement-extractor-filtering-by-category
Jan 13, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This is based off PR 252; just for ease of review i point this to 252 |
lmarini
approved these changes
Jan 13, 2023
7436860
into
252-use-rjsf-to-dynamically-generate-extractor-parameter-forms
lmarini
added a commit
that referenced
this pull request
Jan 17, 2023
* correctly model the extractorInfo * plugin rjsf * rjsf working now * pass in datasetId and fileId to Listeners cannot click on listener unless a file or dataset is selected * dataset and fileid undefined in submitextraction. * moving dispatch * submit extractor now gets parameters correctly. * submit does not work, sending requestBody * adding model for EventListenerSubmit parameters not currently included * extraction does not submit - currently not sending parameters * changing - sending in requestBody but still does not submit * adding back name, does not submit * redeem config change and put example in script * new entry in uvicorn * match codegen * fix submit button and action * correct the file/extract route request params * fix file extraction * fix dataset extraction submission as well * routing key doesn't have extractor.dot there * codegen * fix frontend * fix condition * revert run uvicorn * change 'extractor' to 'listener' in build metadata * add stepper back * close the modal will start over * add listenerInfo * add padding * 253 implement extractor filtering by category (#264) * seperate out the search box of listeners to another component * backend add filter capability * add category filter to the endpoint * add mock filter * automatically generate the fitler options * filter works * frontend handle interaction between searchbox and filters * add an endpoint to get all the distinct categories field * connect frontend with category endpoint * add endpoint to list distinct default labels * add codegen * properly wire the filter * 260 show extractor metadata (#274) * fixing uvicorn, this got overwritten with local (i think by me) * new tab, placeholder * gets metadata with listeners nothing shows yet * adding separate component for each listener metadata entry, currently does not display anything * adding component for contents and listener agent very basic, only works for non-nested metadata * working on nested metadata, only displays top level correctly * json displays properly, need to put each metadata in a box and make metadata collapsible * toggle. can hide or view metadata now * formatting. pipenv run black app * adding new tab to dataset for extractor metadata * changing tab order, tab names, and setting metadata json open by default * metadata from extractors appears in solid boxes. change in font for listener agent. * changing tab order, names for dataset * Added card to extracted metadata entries and fixed grid around them. Co-authored-by: Luigi Marini <[email protected]> Co-authored-by: toddn <[email protected]> Co-authored-by: Todd Nicholson <[email protected]> Co-authored-by: Luigi Marini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
GET /listenersadd new query parametercategoryto enable filteringGET /listeners/categoryto list all the distinct categories in the whole listener collectionGET /listeners/defaultLabelsto list all the distinct labels in the whole listener collectionsearchandfilterare independent of each other: i.e. when searching filter will jump to "all"; when filtering the searchbox will clear outI noticed that there is only "EXTRACT" as the category in most of the V1 extractors; mannually added geospatial as an example