252 use rjsf to dynamically generate extractor parameter forms #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcnichol
force-pushed
the
252-use-rjsf-to-dynamically-generate-extractor-parameter-forms
branch
from
7b682a2 to
e0dff18
Compare
cannot click on listener unless a file or dataset is selected
Contributor
|
@longshuicy right now i am passing in the fileId, datasetId to the SubmitExtraction, but even though they show up in props they are undefined. If you have time to take a look, let me know. |
parameters not currently included
…or-parameter-forms
longshuicy
changed the title
tcnichol
approved these changes
Jan 4, 2023
Contributor
tcnichol
left a comment
tcnichol
left a comment
There was a problem hiding this comment.
I tested with the recent changes. Parameters show up correctly in clowder, submission works, with the right parameters in submission.
* seperate out the search box of listeners to another component * backend add filter capability * add category filter to the endpoint * add mock filter * automatically generate the fitler options * filter works * frontend handle interaction between searchbox and filters * add an endpoint to get all the distinct categories field * connect frontend with category endpoint * add endpoint to list distinct default labels * add codegen * properly wire the filter
* fixing uvicorn, this got overwritten with local (i think by me) * new tab, placeholder * gets metadata with listeners nothing shows yet * adding separate component for each listener metadata entry, currently does not display anything * adding component for contents and listener agent very basic, only works for non-nested metadata * working on nested metadata, only displays top level correctly * json displays properly, need to put each metadata in a box and make metadata collapsible * toggle. can hide or view metadata now * formatting. pipenv run black app * adding new tab to dataset for extractor metadata * changing tab order, tab names, and setting metadata json open by default * metadata from extractors appears in solid boxes. change in font for listener agent. * changing tab order, names for dataset * Added card to extracted metadata entries and fixed grid around them. Co-authored-by: Luigi Marini <[email protected]>
lmarini
approved these changes
Jan 17, 2023
lmarini
deleted the
252-use-rjsf-to-dynamically-generate-extractor-parameter-forms
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready to be reviewed:
To test:
Clear the listeners collection and ingest below documents listeners.json.zip
Go to extractor tab, either try
ncsa.landsat.pipelineor tryncsa.archival.s3extractor