Skip to content

Conversation

@longshuicy
Copy link
Member

Now delete will trigger a get request to the backend to update the new list.

  • I created new redux state (deletedXXXX)
  • whenever item got deleted this state will change
  • Upon listening to such change, a request to the backend to fetch the latest list of resources
  • I also fixed other deletes in the same fashion for API keys, groups, dataset, and metadata definitions.

To test:

  1. Create many files/folders, and delete. The items as well as the pagination should reflect.
  2. Delete datasets
  3. Delete groups. I added a delete button right next to each group
  4. Delete API keys
  5. Delete metadata definition

@longshuicy longshuicy linked an issue May 21, 2024 that may be closed by this pull request
@lmarini
Copy link
Member

lmarini commented May 24, 2024

I think I understand the issue and how you fixed, but I am on main and I can't reproduce :(

If I delete a dataset or a group the list gets updated. In the case of dataset even if it's not on the first page.

@lmarini lmarini merged commit 12e54f1 into main May 24, 2024
@lmarini lmarini deleted the 1053-pagination-doesnt-update-on-deleting-files-in-a-dataset branch May 24, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pagination doesn't update on deleting files in a dataset

3 participants