-
Notifications
You must be signed in to change notification settings - Fork 6
Implementation of feeds page #1056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of feeds page #1056
Conversation
|
need to work on small fixes like page doesn't reload after you edit a feed. working on that but rest is good for review and any feedback. |
longshuicy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- What does index mean?
- Is it possible you could use the styled widgets to avoid the mess up of thebackground style. Feel free to address it in another task though
When I have some unfilled field, then I click save, it becomes a blank page.
If I fill every field, then click save, it is not immediately reflected. I have to refresh the page.
Could we group these two button/icons. Or at least match the table header column, right now it's missing one column
|
Used rjsf/mui instead of rjsf/metrail-ui |
lmarini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that we use a single elasticsearch index, could we remove the index field from both the UI as well as the model?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested creating specific automatic extracting feed and it works as expected.
Delete feeds also works.
I noticed some glitch with edit the feeds though:

In edit mode, seems like I cannot select an extractor. But I can select when in "create" mode.
Thanks for noticing this. In edit mode, it's not showing up the very 1st time you open the edit modal from the Feeds page. I have added some checks to ensure it does. I have removed the edit icon from all over feeds page and kept it there when you click on individual feed. It makes the license loading easier and also is consistent with metdadata defn page.
|
@ddey2 did you push your change? Am I missing anything since I didn't see any updates since my last comment :-( |
My bad. I made the commit and forgot to push it to remote. Now check. |
longshuicy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…eeds page on deletion
Thanks so much for noticing these out. Fixed now. 1 is related to making change to rsjf/mui. Some extra properties are added to make sure those aren't empty. |
longshuicy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything works as expected now. Approved.
…eria-and-save-them









Try to create a feed from UI
Steps to reproduce: