Skip to content

Conversation

@ddey2
Copy link
Member

@ddey2 ddey2 commented May 16, 2024

Try to create a feed from UI

Steps to reproduce:

  1. Go to Feeds menu on the left side pannel
  2. Create a feed
  3. Edit a Feed
  4. Delete a Feed
Screenshot 2024-05-22 at 8 13 36 PM Screenshot 2024-05-22 at 8 07 03 PM Screenshot 2024-05-22 at 8 07 12 PM Screenshot 2024-05-22 at 8 07 36 PM

@ddey2 ddey2 requested review from Vismayak and lmarini May 16, 2024 17:00
@ddey2 ddey2 linked an issue May 16, 2024 that may be closed by this pull request
@ddey2 ddey2 marked this pull request as draft May 16, 2024 17:00
@ddey2 ddey2 marked this pull request as ready for review May 23, 2024 01:19
@ddey2
Copy link
Member Author

ddey2 commented May 23, 2024

need to work on small fixes like page doesn't reload after you edit a feed. working on that but rest is good for review and any feedback.

@ddey2
Copy link
Member Author

ddey2 commented May 30, 2024

Feeds page
Screenshot 2024-05-30 at 10 42 16 AM

Note: the background css of top bar changes when you open a modal. Looking for a fix for that.

Copy link
Member

@longshuicy longshuicy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
  1. What does index mean?
  2. Is it possible you could use the styled widgets to avoid the mess up of thebackground style. Feel free to address it in another task though
image

When I have some unfilled field, then I click save, it becomes a blank page.
If I fill every field, then click save, it is not immediately reflected. I have to refresh the page.

image Could we group these two button/icons. Or at least match the table header column, right now it's missing one column

@ddey2
Copy link
Member Author

ddey2 commented Jun 6, 2024

image 1. What does index mean? 2. Is it possible you could use the styled widgets to avoid the mess up of thebackground style. Feel free to address it in another task though image When I have some unfilled field, then I click save, it becomes a blank page. If I fill every field, then click save, it is not immediately reflected. I have to refresh the page.

image Could we group these two button/icons. Or at least match the table header column, right now it's missing one column

I have made each sub property of feedSchema as required. It should not let you submit the form unless you fill in each details. Please check.

I have grouped the button together
Screenshot 2024-06-06 at 2 02 07 PM

@ddey2
Copy link
Member Author

ddey2 commented Jun 6, 2024

Used rjsf/mui instead of rjsf/metrail-ui
Updated the component name and added dependent components in package.json
Updated several places in code where react json form is used

@ddey2 ddey2 requested a review from longshuicy June 7, 2024 03:24
Copy link
Member

@lmarini lmarini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we use a single elasticsearch index, could we remove the index field from both the UI as well as the model?

@ddey2 ddey2 requested a review from lmarini June 7, 2024 20:11
Copy link
Member

@longshuicy longshuicy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested creating specific automatic extracting feed and it works as expected.
Delete feeds also works.

I noticed some glitch with edit the feeds though:
image
In edit mode, seems like I cannot select an extractor. But I can select when in "create" mode.

Thanks for noticing this. In edit mode, it's not showing up the very 1st time you open the edit modal from the Feeds page. I have added some checks to ensure it does. I have removed the edit icon from all over feeds page and kept it there when you click on individual feed. It makes the license loading easier and also is consistent with metdadata defn page.

@longshuicy
Copy link
Member

@ddey2 did you push your change? Am I missing anything since I didn't see any updates since my last comment :-(

@ddey2
Copy link
Member Author

ddey2 commented Jun 10, 2024

@ddey2 did you push your change? Am I missing anything since I didn't see any updates since my last comment :-(

My bad. I made the commit and forgot to push it to remote. Now check.

@ddey2 ddey2 requested a review from longshuicy June 10, 2024 19:40
Copy link
Member

@longshuicy longshuicy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you reproduce these:

  1. I can set criteria and extractor as empty? I recall you forbids that last time I reviewed
  2. After delete it didn't go away on the frontend

Screenshots attached.
image
image

@ddey2
Copy link
Member Author

ddey2 commented Jun 12, 2024

Could you reproduce these:

  1. I can set criteria and extractor as empty? I recall you forbids that last time I reviewed
  2. After delete it didn't go away on the frontend

Screenshots attached. image image

Thanks so much for noticing these out. Fixed now.

1 is related to making change to rsjf/mui. Some extra properties are added to make sure those aren't empty.

Copy link
Member

@longshuicy longshuicy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works as expected now. Approved.

@longshuicy longshuicy merged commit b9d6a7c into main Jun 13, 2024
@longshuicy longshuicy deleted the 1011-add-frontend-ability-to-add-search-criteria-and-save-them branch June 13, 2024 16:01
@ddey2 ddey2 mentioned this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add frontend ability to add search criteria and save them

4 participants