Update instructions for Fish v4.3 #33
Merged
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
thanks! i have a branch open for 4.3's light/dark sections support, will make a PR and merge that soon too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #32
I simply followed the instructions from the release notes.
I was thinking if there should be instructions for <4.3 and >=4.3. I decided to only include the latest instructions and let that decision to whoever reviews this PR. If the preference is to have both instructions, I'll update this PR to include them.
PS: As I said in the linked issue, Fish also added
[light]and[dark]sections, but after reading the release notes again and checking the built in themes, it seems these sections should only apply to themes that includes both variants, which doesn't apply to Catppuccin.