Add support for v4.3.0

[justbispo]

Seems like the latest fish v4.3.0 changed some things regarding themes.

From what I understood, they now suggest to add fish_config theme choose THEME_NAME to the fish config file. And they also added light and dark theme sections to the theme file.

Right now it doesn't accept theme files with spaces, I've tried everything and nothing worked except removing or replacing the space in the theme file name.

[helenclx]

I'm on fish 4.3.1, and I can still install the Catppuccin theme by following the manual install instructions in the README: move the Catppuccin theme file (with .theme as the file extension), then run fish_config theme save "Catppuccin <flavour>" in the terminal. I can select and set the Catppuccin theme in the fish_config interface too.

You may need to remove the theme-frozen file, which fish will create when migrating to 4.3, from your ~/.config/fish/conf.d first.

[justbispo]

I didn't mention but I had already removed the theme-frozen.
It does work with the file, the colors show up correctly, but obviously that's not the ideal way to have it.

Currently I have the file Catppuccin Macchiato.theme in the ~/.config/fish/themes directory. When I run fish_config theme save "Catppuccin Macchiato" I get the message:

Overwrite your current theme? [y/N] y
cat: /home/user/.config/fish/themes/Catppuccin: No such file or directory
cat: Macchiato.theme: No such file or directory

Edit: The page opened by fish_config doesn't show any themes, a Python error shows up in the terminal, but fish_config theme show shows the themes in the themes/ directory, but still show the same missing files message above the theme.

Edit 2: Also, from the release notes, it seems fish_config theme save saves the values to the fish_variables files again, which is what this updates removes. The suggestion there is to use fish_config theme choose.

[lpnh]

FWIW, my terminal greeted me with the "fish: upgraded to version 4.3" message today too, and this is what worked for me:

• delete the ~/.config/fish/conf.d/fish_frozen_theme.fish and ~/.config/fish/conf.d/fish_frozen_key_bindings.fish files
• set my theme via fish_config theme choose in ~/.config/fish/config.fish:

fish_config theme choose "Catppuccin Mocha"

The Usage section in the README should probably be updated, following the 4.3 release note suggestion.

[justbispo]

After trying putting the fish_config in multiple places inside the config file, I found out it was an issue with grc. Putting the line before sourcing grc fixed it.

Edit: For someone who might bump into this issue, using Oh My Fish's plugin-grc is the best solution. Not only helps overriding a command supported by grc, e.g. alias ls='grc ls -la' (this only works if including in config.fish, since config.fish is sourced after conf.d scripts, where I'm saving my aliases), by using grcplugin_commandname, but also solves the issue I had here:

Edit: The page opened by fish_config doesn't show any themes, a Python error shows up in the terminal, but fish_config theme show shows the themes in the themes/ directory, but still show the same missing files message above the theme.

[helenclx]

I can confirm that setting fish shell's theme by adding fish_config theme choose to ~/.config/fish/config.fish works.

I tested it by removing fish_variables from ~/.config/fish/, restarting the shell to let fish regenerate fish_variables, setting the shell theme to the default in fish_config, then adding fish_config theme choose "Catppuccin Mocha" to ~/.config/fish/config.fish and restarting the fish shell.