Skip to content

fix: Error when using EDITOR environment variable with arguments #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
caarlos0 merged 2 commits into from
Mar 6, 2022
Merged

fix: Error when using EDITOR environment variable with arguments #44

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33368cc
Read arguments of command in EDITOR env variable and pass them
Mar 4, 2022
8d2a6dc
fix: Improved solution by making use of strings.Fields
Mar 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions internal/cmd/edit.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@ package cmd

import (
"fmt"
"log"
"os"
"os/exec"
"path/filepath"
"strings"
"time"

"github.com/spf13/cobra"
Expand All @@ -28,13 +28,19 @@ func newEditCmd() *editCmd {
return err
}

editor := os.Getenv("EDITOR")
if editor == "" {
editor := strings.Fields(os.Getenv("EDITOR"))
if len(editor) == 0 {
return fmt.Errorf("no $EDITOR set")
}

log.Printf("%s %s\n", editor, tmp)
edit := exec.Command(editor, tmp)
editorCmd := editor[0]
var editorArgs []string
if len(editor) > 1 {
editorArgs = append(editorArgs, editor[1:]...)
}
editorArgs = append(editorArgs, tmp)

edit := exec.Command(editorCmd, editorArgs...)
edit.Stderr = os.Stderr
edit.Stdout = os.Stdout
edit.Stdin = os.Stdin
Expand Down