fix: Error when using EDITOR environment variable with arguments

[stefan-fast]

Hello there!
First of all, thanks for this awesome little project :)

Description

This PR tries to fix the issue of using the tt edit command in combination with an EDITOR environment variable that consists of a command with arguments.

Issue

Example

I am using EDITOR="code --wait" as my environment variable for starting Visual Studio Code. Currently, this gives the following output:

❯ export EDITOR="code --wait"
❯ tt edit
Error: exec: "code --wait": executable file not found in $PATH

Reason

The whole string "code --wait" is passed to exec.Command as the first argument. By documentation, only the command itself should be the first argument of exec.Command and any arguments of that command should follow as seperate arguments.

Solution

If there are any spaces in the environment variable EDITOR, the command and it's argument are split into two seperate arguments for exec.Command.

In my testing both

❯ export EDITOR="code --wait"
❯ tt edit

and

❯ export EDITOR="nano"
❯ tt edit

worked fine with the proposed fix.

[caarlos0]

I think we can make this a bit nicer:

editor := strings.Fields(os.Getenv("EDITOR"))
if len(editor) == 0 {
  return fmt.Errorf("no $EDITOR set")
}

cmd := editor[0]
var args []string
if len(editor) > 1 {
  args = append(args, editor[1:])
}
args = append(args, tmp)

edit := exec.Command(cmd, args)
// ...

wdyt?

[stefan-fast]

Nice, I didn't know strings.Fields yet. Thanks for the suggestion, I'll update the PR in just a moment. I have to rename the variables though since cmd and args are the parameter names of the function already :)

[caarlos0]

thanks!