This repository was archived by the owner on May 26, 2022. It is now read-only.
Add Sound Effect to Notification #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TamasGorgics
commented
Jul 9, 2019
TamasGorgics
commented
Jul 9, 2019
- Add tslint ignore for floating promise
beeequeue
approved these changes
Jul 9, 2019
|
👏 |
Contributor
Author
|
Sorry for hijacking your PR @TarekMostafaHr but the temptation was too strong 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on this PR.
Future plans: add mute button (or even a volume controller if possible) and other sounds to choose from. 🔨
Closes #9
Closes #19