This repository was archived by the owner on May 26, 2022. It is now read-only.
Add Sound Effect #19
Closed
Add Sound Effect #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beeequeue
suggested changes
May 2, 2019
| const sound = new Audio(soundLink) | ||
|
|
||
| if (sound) { | ||
| sound.load() |
Owner
There was a problem hiding this comment.
It's probably better if we create and load the sound once instead of every time playSound is called, and then simply call play() whenever we need to.
Possibly pass an Audio instance instead of a string, load the audio if hasn't been already and then play it?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add sound effect
Notification API has sound prop but not supported by any browser now, as a work around we used Audio API