Joaosoumoreira/add method to enroll email mfa #744
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Currently there is no way to add an email channel oob authenticator because the existing
addOobAuthenticatoronly supports adding a phone number even though you can set any oob channel. This PR will splitaddOobAuthenticatorintoaddPhoneOobAuthenticatorandaddEmailOobAuthenticatoralong with test coverage for the email based method.I was initially thinking of keeping the single method and consolidating all of the logic inside but I feel like a clear separation makes the code easier to understand and test.
References
#603
Testing
This can be manually tested by calling either
addPhoneOobAuthenticatororaddEmailOobAuthenticatorin your projects and seeing either a valid response from the API or an error.Checklist
Credits
Thank you @JoaoSouMoreira for helping with #737