Skip to content

Conversation

@tanya732
Copy link
Contributor

@tanya732 tanya732 commented Aug 5, 2025

Changes

Currently there is no way to add an email channel oob authenticator because the existing addOobAuthenticator only supports adding a phone number even though you can set any oob channel. This PR will split addOobAuthenticator into addPhoneOobAuthenticator and addEmailOobAuthenticator along with test coverage for the email based method.

I was initially thinking of keeping the single method and consolidating all of the logic inside but I feel like a clear separation makes the code easier to understand and test.

References

#603

Testing

This can be manually tested by calling either addPhoneOobAuthenticator or addEmailOobAuthenticator in your projects and seeing either a valid response from the API or an error.

  • This change adds test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

Credits

Thank you @JoaoSouMoreira for helping with #737

@tanya732 tanya732 marked this pull request as ready for review August 5, 2025 16:14
@tanya732 tanya732 requested a review from a team as a code owner August 5, 2025 16:14
@tanya732 tanya732 merged commit a3b6219 into master Aug 11, 2025
6 checks passed
@tanya732 tanya732 deleted the joaosoumoreira/add-method-to-enroll-email-mfa branch August 11, 2025 05:55
@tanya732 tanya732 mentioned this pull request Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants