Create new method to add Email based OOB authenticator and tests

[JoaoSouMoreira]

Changes

Currently there is no way to add an email channel oob authenticator because the existing addOobAuthenticator only supports adding a phone number even though you can set any oob channel. This PR will split addOobAuthenticator into addPhoneOobAuthenticator and addEmailOobAuthenticator along with test coverage for the email based method.

I was initially thinking of keeping the single method and consolidating all of the logic inside but I feel like a clear separation makes the code easier to understand and test.

References

#603

Testing

This can be manually tested by calling either addPhoneOobAuthenticator or addEmailOobAuthenticator in your projects and seeing either a valid response from the API or an error.

• This change adds test coverage
• This change has been tested on the latest version of the platform/language or why not

Checklist

• I have read the Auth0 general contribution guidelines
• I have read the Auth0 Code of Conduct
• All existing and new tests complete without errors

[tanya732]

Hi @JoaoSouMoreira

Thank you for opening the PR! I appreciate your contribution. I'll review it shortly.

Thank you

[tanya732]

Hi @JoaoSouMoreira

Thanks for the contribution! I noticed the Codecov patch check is currently failing because the test coverage for the changes is below the required threshold (88.46% vs 96.95%). Would you mind adding some additional tests to bring coverage up? Let me know if you need help.

[JoaoSouMoreira]

Hi @JoaoSouMoreira

Thanks for the contribution! I noticed the Codecov patch check is currently failing because the test coverage for the changes is below the required threshold (88.46% vs 96.95%). Would you mind adding some additional tests to bring coverage up? Let me know if you need help.

I've added tests covering as much as I could for both implementations of addOobAuthenticator.

[tanya732]

@JoaoSouMoreira

I missed to check, can you please sign your commits ?

Thank you

[JoaoSouMoreira]

@JoaoSouMoreira

I missed to check, can you please sign your commits ?

Thank you

This is done. If this is something that is generally requested for open source contributions I would recommend that it be added to the Contributing guidelines so folks are aware.

[tanya732]

@JoaoSouMoreira

Thank you for signing the commits and pointing it out the Contributing guidelines, I will update the doc.

I have merged your changes and created #744. Will release this change in next release.

Thank you

[JoaoSouMoreira]

@JoaoSouMoreira

Thank you for signing the commits and pointing it out the Contributing guidelines, I will update the doc.

I have merged your changes and created #744. Will release this change in next release.

Thank you

Sounds good, thank you. Do you have a rough timeline on when the next release is planned to come out?

[tanya732]

Hi @JoaoSouMoreira

The changes have been successfully released and can be found here

Accordingly, I am closing the PR.

Thank you for your contribution!