Skip to content

ADFA-1729-Change-permissions-strings-to-cover-Android12-differences#861

Merged
hal-eisen-adfa merged 2 commits intostagefrom
ADFA-1729-Change-permissions-strings-to-cover-Android12-differences
Jan 24, 2026
Merged

ADFA-1729-Change-permissions-strings-to-cover-Android12-differences#861
hal-eisen-adfa merged 2 commits intostagefrom
ADFA-1729-Change-permissions-strings-to-cover-Android12-differences

Conversation

@Elissa-AppDevforAll
Copy link
Collaborator

Updated permission information on the installer page about permissions.

  • The first block says "up to four" instead of just four to cover Android 12 or earlier only showing three.
  • The first bullet explains that you won't be asked for Notifications permission on Android 12 or earlier.

Updated permission information for notifications and intro.
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 20, 2026

📝 Walkthrough
  • Updated permission request text — Modified the installer permissions intro to say "up to four" permissions instead of "four" to accurately reflect Android 12 (and earlier) behavior where the Notifications permission may not be shown.

  • Added Android 12 clarification for Notifications permission — Appended explanatory text to the Notifications bullet noting that on Android 12 and earlier, notifications are enabled by default and won’t appear as a separate permission request.

  • Files changed: resources/src/main/res/values/strings.xml (two string value updates; no code changes)

Notes:

  • Risk level: Low — Only UI string changes; no control flow, logic, or manifest permission changes.
  • Best practices: These clarifications improve user transparency about OS-specific permission behavior and align with guidance to surface platform differences in UI text.

Walkthrough

Updates two string resources to clarify permissions messaging: permissions_info_intro now indicates "up to four" permissions, and permissions_info_notifications adds a note that on Android 12 and earlier notifications are enabled by default and won’t appear as a separate permission request.

Changes

Cohort / File(s) Summary
String Resource Updates
resources/src/main/res/values/strings.xml
Updated permissions_info_intro to specify "up to four permissions". Extended permissions_info_notifications with a note explaining Android 12 and earlier default notification behavior and that it won’t appear as a separate permission request.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A string here, a string there,
Permissions clearer everywhere!
"Up to four" now rings so true,
Android twelve gets context too!
Hooray — the messages are new! 🎉

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly references the main change (handling Android 12 permission differences) and is directly supported by both string updates in the changeset.
Description check ✅ Passed The description is clearly related to the changeset, explaining the two string updates and their purpose regarding Android 12 permission behavior differences.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@hal-eisen-adfa hal-eisen-adfa merged commit f7d38c5 into stage Jan 24, 2026
2 checks passed
@hal-eisen-adfa hal-eisen-adfa deleted the ADFA-1729-Change-permissions-strings-to-cover-Android12-differences branch January 24, 2026 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants