ADFA-3253 | Skip llama asset bundling in debug CI builds#1071
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 Walkthrough
Risks & Best Practices
WalkthroughAdds a CI environment variable Changes
Sequence Diagram(s)(Skipped — changes are build/config focused and do not introduce a multi-component runtime control-flow requiring sequence visualization.) Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can customize the tone of the review comments and chat replies.Configure the |
chore: add configurable flag for llama asset dependencies
904d09a to
0f5441b
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@app/build.gradle.kts`:
- Around line 759-761: The current log message for skipLlamaAssets
(project.logger.lifecycle call) is misleading because it states only debug
assemble tasks are skipped while the lint task wiring is also gated by
skipLlamaAssets; update the lifecycle message to accurately reflect all affected
tasks (e.g., mention both assemble/debug bundling and lint task wiring) so it
clearly communicates the broader behavior controlled by the skipLlamaAssets
flag.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: ff3a0746-bd46-4d95-adac-23e3ce36493d
📒 Files selected for processing (2)
.github/workflows/debug.ymlapp/build.gradle.kts
🚧 Files skipped from review as they are similar to previous changes (1)
- .github/workflows/debug.yml
Description
This PR introduces a configurable
skipLlamaAssetsflag to prevent debug CI builds from triggering llama asset bundling tasks.The objective is to reduce CI build time by avoiding expensive llama asset generation during debug APK builds while preserving the existing behavior for release builds.
Details
skipLlamaAssetsflag inapp/build.gradle.ktsSKIP_LLAMA_ASSETS=truein the debug CI workflowTicket
ADFA-3253
Observation
Release build wiring remains unchanged to ensure bundled llama assets are still generated for release APK packaging. The change only affects debug CI builds.