Skip to content

ADFA-2615 (fix): Add No noCompressExtensions to debug APKs to fix missing tflite assets#860

Merged
Daniel-ADFA merged 2 commits intostagefrom
ADFA-2615
Jan 21, 2026
Merged

ADFA-2615 (fix): Add No noCompressExtensions to debug APKs to fix missing tflite assets#860
Daniel-ADFA merged 2 commits intostagefrom
ADFA-2615

Conversation

@Daniel-ADFA
Copy link
Contributor

@Daniel-ADFA Daniel-ADFA commented Jan 20, 2026

No description provided.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 20, 2026

📝 Walkthrough

Walkthrough

This change propagates the noCompressExtensions property to the recompressApk task configurations across four APK assembly variants (V8/V7, Debug/Release), ensuring the recompression logic respects the defined no-compression extension list.

Changes

Cohort / File(s) Summary
APK Recompression Configuration
app/build.gradle.kts
Propagates noCompressExtensions property by setting extensions.extraProperties["noCompressExtensions"] = noCompress in assembleV8Release, assembleV7Release, assembleV8Debug, and assembleV7Debug task configurations to exclude specified file extensions from APK recompression.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • jomen-adfa
  • jatezzz

Poem

🐰 Extensions fly with no compress in sight,
Through V8 and V7, Debug and Release bright,
Four variants aligned in graceful array,
APK recompression knows the no-compress way! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to assess whether the description is related to the changeset. Add a description explaining the purpose of propagating noCompressExtensions to debug APK tasks and how this addresses the missing tflite assets issue.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title references the main change (adding noCompressExtensions to debug APKs) and its purpose (fixing missing tflite assets), but contains a typo ('No noCompressExtensions' appears redundant) and could be more concise.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Daniel-ADFA Daniel-ADFA changed the title (fix): Add No noCompressExtensions to debug APKs to fix missing tflite assets ADFA-2615 (fix): Add No noCompressExtensions to debug APKs to fix missing tflite assets Jan 20, 2026
@Daniel-ADFA Daniel-ADFA merged commit eb69f78 into stage Jan 21, 2026
2 checks passed
@Daniel-ADFA Daniel-ADFA deleted the ADFA-2615 branch January 21, 2026 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants