Skip to content

THRIFT-5776: Cpp cross test fail test#2968

Closed
CJCombrink wants to merge 2 commits intoapache:masterfrom
CJCombrink:bugfix/THRIFT-5776_cross_test_uuid
Closed

THRIFT-5776: Cpp cross test fail test#2968
CJCombrink wants to merge 2 commits intoapache:masterfrom
CJCombrink:bugfix/THRIFT-5776_cross_test_uuid

Conversation

@CJCombrink
Copy link
Copy Markdown
Contributor

@CJCombrink CJCombrink commented Apr 27, 2024

THRIFT-5776

  • Not yet sure where the issue might be
  • Did you create an Apache Jira ticket? (Request account here, not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@CJCombrink CJCombrink force-pushed the bugfix/THRIFT-5776_cross_test_uuid branch from da9310f to d01ceb8 Compare April 28, 2024 19:32
MaoZiming pushed a commit to Trinity-data-store/Trinity that referenced this pull request Apr 30, 2024
* fix: include flex and bison in dependency setup script

* fix: space missing for thrift installation block

* fix: add pkgconf in setup script

* refactor: switch to a stable release of thrift

main stream seems to have a bug that prevents compilation at this time apache/thrift#2968
@Jens-G
Copy link
Copy Markdown
Member

Jens-G commented May 1, 2024

Still draft?

@CJCombrink
Copy link
Copy Markdown
Contributor Author

@Jens-G I still need to look into the latest errors as mentioned on the ticket.
However when I was testing this was sufficient to to get the build/docker/scripts/autotools.sh script to pass, but the OP seems to have more issues.

@CJCombrink CJCombrink force-pushed the bugfix/THRIFT-5776_cross_test_uuid branch from 5ebbe73 to 3f708a7 Compare May 6, 2024 19:11
@CJCombrink
Copy link
Copy Markdown
Contributor Author

@Jens-G Sorry for the delay, I am looking into this this week, I could not over the weekend.

@CJCombrink CJCombrink marked this pull request as ready for review May 7, 2024 05:18
@CJCombrink
Copy link
Copy Markdown
Contributor Author

@Jens-G The last commits at least fixes the compile errors in the 'ubuntu-jammy' docker containers as well.
I have not implemented any cross tests, just made it compile.
I can look at better cross tests but would like to get some feedback on THRIFT-5773 so that I can do the work there.

After these changes I now also get THRIFT-5775 as per the original ticket tracking this issue.

@CJCombrink CJCombrink force-pushed the bugfix/THRIFT-5776_cross_test_uuid branch from 2ae8f2a to 7a05842 Compare May 31, 2024 19:07
- Not yet sure where the issue might be
- Define the functions
- Cross test of UUID not implemented
@CJCombrink CJCombrink force-pushed the bugfix/THRIFT-5776_cross_test_uuid branch from 7a05842 to 5032009 Compare June 8, 2024 12:18
@CJCombrink CJCombrink mentioned this pull request Jun 9, 2024
5 tasks
@CJCombrink
Copy link
Copy Markdown
Contributor Author

Fixed as part of #2958

@CJCombrink CJCombrink closed this Jun 21, 2024
bl-rr pushed a commit to bl-rr/trinity-fork-1 that referenced this pull request May 18, 2025
* fix: include flex and bison in dependency setup script

* fix: space missing for thrift installation block

* fix: add pkgconf in setup script

* refactor: switch to a stable release of thrift

main stream seems to have a bug that prevents compilation at this time apache/thrift#2968
@CJCombrink CJCombrink deleted the bugfix/THRIFT-5776_cross_test_uuid branch November 6, 2025 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants