Fix Node Setup Script#1
Merged
MaoZiming merged 4 commits intoTrinity-data-store:mainfrom Apr 30, 2024
developStorm:patch-1
Merged
Fix Node Setup Script#1MaoZiming merged 4 commits intoTrinity-data-store:mainfrom developStorm:patch-1
MaoZiming merged 4 commits intoTrinity-data-store:mainfrom
developStorm:patch-1
Conversation
main stream seems to have a bug that prevents compilation at this time apache/thrift#2968
MaoZiming
force-pushed
the
main
branch
2 times, most recently
from
76d35b2 to
299bad4
Compare
Member
|
Thanks! |
bl-rr
pushed a commit
to bl-rr/Trinity
that referenced
this pull request
Jun 18, 2025
* fix: include flex and bison in dependency setup script * fix: space missing for thrift installation block * fix: add pkgconf in setup script * refactor: switch to a stable release of thrift main stream seems to have a bug that prevents compilation at this time apache/thrift#2968
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the great work, enjoyed reading your paper :D
This PR includes 4 fixes:
46153ef fixes the following error:
(and similarly for
flex)ced22d5 fixes a missing space that caused the
iftest for the Thrift installation to fail. It also addsset -Eeuo pipefailto the top of the script to ensure the script fails fast in case of an error like this, as a precaution.c3a704f installs
pkgconfas a dependency for compiling Thrift. See: https://issues.apache.org/jira/browse/THRIFT-491082e3ade switches to using a stable release of Thrift (I randomly selected the latest 0.20.0, which seems to work well with the Trinity compilation) to avoid a bug in the current git main branch of Thrift, and to ensure the script installs a version of Thrift that is confirmed to work with Trinity, instead of always opting for the latest commit.