TEZ-4407: Misleading split info in TezSplitGrouper logs when adjusting small splits

[zabetak]

No description provided.

[abstractdog]

what about adding an else branch here with some useful log message describing whatever happens (or doesn't happen) when allSplitsHaveLocalhost=true
otherwise LGTM
cc: @rbalamohan

[zabetak]

I added a log message here c715c0b and also made a small refactoring to gather logging in one place and always log if splitLength bounds are exceeded.

Anyways the most important point in this patch is to be able to see the original desiredNumSplits in every case; especially when it is different from newDesiredNumSplits or not.

[tez-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 34s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1 💚	mvninstall	16m 11s	master passed
+1 💚	compile	0m 33s	master passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1
+1 💚	compile	0m 30s	master passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu122.04-b09
+1 💚	checkstyle	1m 14s	master passed
+1 💚	javadoc	0m 42s	master passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1
+1 💚	javadoc	0m 26s	master passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu122.04-b09
+0 🆗	spotbugs	1m 19s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	1m 17s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 19s	the patch passed
+1 💚	compile	0m 20s	the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1
+1 💚	javac	0m 20s	the patch passed
+1 💚	compile	0m 18s	the patch passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu122.04-b09
+1 💚	javac	0m 18s	the patch passed
+1 💚	checkstyle	0m 11s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	0m 17s	the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1
+1 💚	javadoc	0m 16s	the patch passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu122.04-b09
+1 💚	findbugs	0m 44s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 26s	tez-mapreduce in the patch passed.
+1 💚	asflicense	0m 15s	The patch does not generate ASF License warnings.
		26m 40s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-202/2/artifact/out/Dockerfile
GITHUB PR	#202
JIRA Issue	TEZ-4407
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
uname	Linux 53b947cf7a6f 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/tez.sh
git revision	master / 7a56e9b
Default Java	Private Build-1.8.0_362-8u372-gaus1-0ubuntu122.04-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-gaus1-0ubuntu122.04-b09
Test Results	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-202/2/testReport/
Max. process+thread count	222 (vs. ulimit of 5500)
modules	C: tez-mapreduce U: tez-mapreduce
Console output	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-202/2/console
versions	git=2.34.1 maven=3.6.3 findbugs=3.0.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.