TEZ-4396 Ensure utility classes have only private (default) constructors#197
Merged
abstractdog merged 1 commit intoapache:masterfrom Nov 26, 2022
Merged
TEZ-4396 Ensure utility classes have only private (default) constructors#197abstractdog merged 1 commit intoapache:masterfrom
abstractdog merged 1 commit intoapache:masterfrom
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
|
@ghanko : is there a chance you can rebase this change and address the remaining related checkstyle issues? |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Change-Id: I0cf2653338a74379bdfefc87430859aa114bbdfa
|
🎊 +1 overall
This message was automatically generated. |
abstractdog
approved these changes
Nov 26, 2022
Contributor
abstractdog
left a comment
There was a problem hiding this comment.
+1
I'm about to change the commit message to reflect that this commit includes lots of refactors other than final classes
thanks @ghanko , this is a great code quality improvement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.