-
Notifications
You must be signed in to change notification settings - Fork 1.3k
CKS CoreOS EOL update #4436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CKS CoreOS EOL update #4436
Changes from all commits
f4bd8ab
348b76d
da5e16a
64dc779
3fed479
e87b25c
f9286d7
9adcded
e0120b9
06a7d36
237981a
3367e18
d7a3993
d78eb35
8e3a25d
5888e77
d4c179c
dbdaf45
013f61f
e4fa75f
92d7271
1d95188
07eea78
039fed5
88da9c1
e90b2de
f60b33c
b9ca4f7
4766669
d703091
6728047
a668a62
4669eb0
0deca68
cd0f562
68b8a32
7a37c13
0a53091
59d70d9
8f0c03c
e65d32a
41a7eac
31ad3c2
b545d49
ce9774c
22bb446
89877c2
f2bf49c
3bd04bf
201fdda
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -48,6 +48,9 @@ public class UserVmVO extends VMInstanceVO implements UserVm { | |
| @Column(name = "update_parameters", updatable = true) | ||
| protected boolean updateParameters = true; | ||
|
|
||
| @Column(name = "user_vm_type", updatable = true) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can use "type" from VMInstanceVO instead? |
||
| private String userVmType; | ||
|
|
||
| transient String password; | ||
|
|
||
| @Override | ||
|
|
@@ -125,4 +128,12 @@ public void setUpdateParameters(boolean updateParameters) { | |
| public boolean isUpdateParameters() { | ||
| return updateParameters; | ||
| } | ||
|
|
||
| public String getUserVmType() { | ||
| return userVmType; | ||
| } | ||
|
|
||
| public void setUserVmType(String userVmType) { | ||
| this.userVmType = userVmType; | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -833,3 +833,15 @@ INSERT INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_vers | |
|
|
||
| -- Fix OS category for Guest OS 'Other PV Virtio-SCSI (64-bit)' | ||
| UPDATE `cloud`.`guest_os` SET category_id = 7 WHERE id = 275 AND display_name = 'Other PV Virtio-SCSI (64-bit)'; | ||
|
|
||
| -- TODO : Move to 4.16 | ||
| ALTER TABLE `cloud`.`user_vm` ADD COLUMN `user_vm_type` varchar(255) DEFAULT "UserVM" COMMENT 'Defines the type of UserVM'; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @Pearl1594 is this not redundant of Type column in vm_instance table? This type column already used to persist different system VMs (ConsoleProxy, SecondaryStorageVm, DomainRouter), may be you can use this for different user VMs as well.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Intention of adding a user vm type - as a sub-type of VMInstance type - User is to basically reduce any regression - changing User to other type to accommodate CKS / K8s nodes would possibly require a lot more changes
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ok @Pearl1594 I think it is better to use single source for defining the instance type. |
||
|
|
||
| UPDATE `cloud`.`vm_template` set deploy_as_is = 1 where id = 8; | ||
|
|
||
| ALTER TABLE `cloud`.`kubernetes_cluster` ADD COLUMN `autoscaling_enabled` tinyint(1) unsigned NOT NULL DEFAULT 0; | ||
| ALTER TABLE `cloud`.`kubernetes_cluster` ADD COLUMN `minsize` bigint; | ||
| ALTER TABLE `cloud`.`kubernetes_cluster` ADD COLUMN `maxsize` bigint; | ||
|
|
||
| ALTER TABLE `cloud`.`kubernetes_cluster_vm_map` ADD COLUMN `is_master` tinyint(1) unsigned NOT NULL DEFAULT 0; | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please note there is already a specific PR #4437 with this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was added to verify the fix @sureshanaparti