CKS CoreOS EOL update #4436

Pearl1594 · 2020-10-29T12:47:18Z

Description

With CoreOS having reached End of life, support has been provided CKS to consume systemVM template to deploy kubernetes clusters

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

…s_flatcar

…s_debian

… deployment

…_debian

…anges

…s_debian

Pearl1594 · 2020-10-30T03:56:21Z

@blueorangutan package

blueorangutan · 2020-10-30T03:57:43Z

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-10-30T04:17:37Z

Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2312

Pearl1594 · 2020-10-30T04:29:01Z

@blueorangutan package

blueorangutan · 2020-10-30T04:29:38Z

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

sureshanaparti · 2020-10-30T04:59:32Z

engine/schema/src/main/resources/META-INF/db/schema-41400to41500.sql

 -- Fix OS category for Guest OS 'Other PV Virtio-SCSI (64-bit)'
 UPDATE `cloud`.`guest_os` SET category_id = 7 WHERE id = 275 AND display_name = 'Other PV Virtio-SCSI (64-bit)';
+
+ALTER TABLE `cloud`.`user_vm` ADD COLUMN `user_vm_type` varchar(255) DEFAULT "UserVM" COMMENT 'Defines the type of UserVM';


@Pearl1594 is this not redundant of Type column in vm_instance table? This type column already used to persist different system VMs (ConsoleProxy, SecondaryStorageVm, DomainRouter), may be you can use this for different user VMs as well.

Intention of adding a user vm type - as a sub-type of VMInstance type - User is to basically reduce any regression - changing User to other type to accommodate CKS / K8s nodes would possibly require a lot more changes

Ok @Pearl1594 I think it is better to use single source for defining the instance type.

sureshanaparti · 2020-10-30T05:00:57Z

engine/schema/src/main/java/com/cloud/vm/UserVmVO.java

    @Column(name = "update_parameters", updatable = true)
    protected boolean updateParameters = true;

+    @Column(name = "user_vm_type", updatable = true)


can use "type" from VMInstanceVO instead?

blueorangutan · 2020-10-30T05:02:18Z

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2313

sureshanaparti · 2020-10-30T05:04:05Z

...chestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java

        List<DatadiskTO> templateAsIsDisks = null;
        String configurationId = null;
-        if (template.isDeployAsIs()) {
+        if (template.isDeployAsIs() && vm.getType() != VirtualMachine.Type.SecondaryStorageVm) {


please note there is already a specific PR #4437 with this change

This was added to verify the fix @sureshanaparti

sureshanaparti · 2020-10-30T05:31:52Z

server/src/main/java/com/cloud/vm/UserVmManager.java


    static final int MAX_USER_DATA_LENGTH_BYTES = 2048;

+    public static enum UserVmType {


@Pearl1594 there is a common enum "VirtualMachine.Type" where all the VM types are defined, can use the same?

Pearl1594 · 2020-10-30T14:32:55Z

@blueorangutan package

blueorangutan · 2020-10-30T14:33:45Z

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-10-30T15:05:22Z

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2316

… into cks_debian

Pearl Dsilva and others added 30 commits September 17, 2020 09:49

prevent NPE during ssh key reset

f4bd8ab

Merge branch 'master' of https://github.com/apache/cloudstack into ck…

348b76d

…s_flatcar

Merge branch 'master' of https://github.com/apache/cloudstack into ck…

da5e16a

…s_flatcar

Initial Commit - Debian template as replacement for CoreOS

64dc779

Merge branch 'master' of https://github.com/apache/cloudstack into ck…

3fed479

…s_debian

Support for cks nodes to use systemvm template

e87b25c

Allow usage of systemvm template by other accounts during k8s cluster…

f9286d7

… deployment

Refactor tests + allow user to use SystemVM template during scaling

9adcded

Fix additional master config file

e0120b9

remove redundant lines

06a7d36

Formatted code

237981a

temporary checksum update

3367e18

change guest os id for xenserver

d7a3993

Adding public ip to listKubernetesClusterResponse

d78eb35

Guestos id for vmware

8e3a25d

Cleaned up code

5888e77

Merge branch 'add-cks-ip' of github.com:shapeblue/cloudstack into cks…

d4c179c

…_debian

Wait for ssh to become available before attaching ISO and template ch…

dbdaf45

…anges

Merge branch 'master' of https://github.com/apache/cloudstack into ck…

013f61f

…s_debian

Merge branch 'master' of https://github.com/apache/cloudstack into ck…

e4fa75f

…s_debian

debug logs

92d7271

commit addresses systemvm iso not getting attached during bootup

1d95188

Adding nodeid param in scalekubecluster

07eea78

Changing cks nomenclature

039fed5

Adding isMaster in KubernetesClusterVmMap

88da9c1

Ensuring we dont remove all masters

e90b2de

Deploying the autoscaler

f60b33c

Adding public ip to listKubernetesClusterResponse

b9ca4f7

Adding api keys during cluster creation

4766669

Cleanup

d703091

davidjumani and others added 4 commits October 29, 2020 16:35

Refactoring

8f0c03c

Adding logs for upgrade failure

e65d32a

More cleanup

41a7eac

Cleanup + set vmware systemvm template deploy_as_is to 1

31ad3c2

Pearl1594 added this to the 4.16.0.0 milestone Oct 29, 2020

PaulAngus added the type:enhancement label Oct 29, 2020

Pearl Dsilva added 2 commits October 30, 2020 09:20

Merge branch 'master' of https://github.com/apache/cloudstack into ck…

b545d49

…s_debian

fix for systemvm template - deploy as is field

ce9774c

code cleanup

22bb446

Pearl1594 force-pushed the cks_debian branch from be4d848 to 22bb446 Compare October 30, 2020 04:19

sureshanaparti reviewed Oct 30, 2020

View reviewed changes

Additional details to support deployment on shared network

89877c2

Limiting max cluster size to global setting KubernetesMaxClusterSize

f2bf49c

Pearl1594 force-pushed the cks_debian branch from d089a6d to cec47df Compare November 2, 2020 05:56

Support for shared networks

3bd04bf

Pearl1594 force-pushed the cks_debian branch from cec47df to 3bd04bf Compare November 2, 2020 06:09

Merge branch 'add-cks-autoscaling' of github.com:shapeblue/cloudstack…

201fdda

… into cks_debian

Pearl1594 closed this Nov 2, 2020


		static final int MAX_USER_DATA_LENGTH_BYTES = 2048;

		public static enum UserVmType {

CKS CoreOS EOL update #4436

CKS CoreOS EOL update #4436

Uh oh!

Conversation

Pearl1594 commented Oct 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Uh oh!

Pearl1594 commented Oct 30, 2020

Uh oh!

blueorangutan commented Oct 30, 2020

Uh oh!

blueorangutan commented Oct 30, 2020

Uh oh!

Pearl1594 commented Oct 30, 2020

Uh oh!

blueorangutan commented Oct 30, 2020

Uh oh!

sureshanaparti Oct 30, 2020

Choose a reason for hiding this comment

Uh oh!

Pearl1594 Oct 30, 2020

Choose a reason for hiding this comment

Uh oh!

sureshanaparti Oct 30, 2020

Choose a reason for hiding this comment

Uh oh!

sureshanaparti Oct 30, 2020

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Oct 30, 2020

Uh oh!

sureshanaparti Oct 30, 2020

Choose a reason for hiding this comment

Uh oh!

Pearl1594 Oct 30, 2020

Choose a reason for hiding this comment

Uh oh!

sureshanaparti Oct 30, 2020

Choose a reason for hiding this comment

Uh oh!

Pearl1594 commented Oct 30, 2020

Uh oh!

blueorangutan commented Oct 30, 2020

Uh oh!

blueorangutan commented Oct 30, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Pearl1594 commented Oct 29, 2020 •

edited

Loading