Revert "[BEAM-3182] Ensure nexmark model tests produce output"#4836
Closed
apilloud wants to merge 1 commit intoapache:masterfrom
Closed
Revert "[BEAM-3182] Ensure nexmark model tests produce output"#4836apilloud wants to merge 1 commit intoapache:masterfrom
apilloud wants to merge 1 commit intoapache:masterfrom
Conversation
Member
|
It seems as though by enabling running Query6 so that it actually produced output, the tests started to fail. |
lukecwik
approved these changes
Mar 8, 2018
Member
|
LGTM when green. |
Member
|
Talked this over and actually it appears that the failure is caused by (1) the query has always been wrong (2) the data size was never large enough to find that. Separately (3) the model was made more correct. So I think this is something that should be sickbayed and filed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #4745 it causes flakes.