[BEAM-3182] Ensure nexmark model tests produce output#4745
Merged
kennknowles merged 2 commits intoapache:masterfrom Mar 8, 2018
Merged
[BEAM-3182] Ensure nexmark model tests produce output#4745kennknowles merged 2 commits intoapache:masterfrom
kennknowles merged 2 commits intoapache:masterfrom
Conversation
Member
Author
|
R: @kennknowles |
Member
Author
|
Ping @kennknowles |
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the Nexmark model tests don't produce any output at the current number of events. This change ensures every test produces some output. It also changes the Query 6 model to match the Query 6 implementation, but it still doesn't match the benchmark specification.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue.mvn clean verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.