Skip to content

[BEAM-3182] Ensure nexmark model tests produce output#4745

Merged
kennknowles merged 2 commits intoapache:masterfrom
apilloud:nexmark-models
Mar 8, 2018
Merged

[BEAM-3182] Ensure nexmark model tests produce output#4745
kennknowles merged 2 commits intoapache:masterfrom
apilloud:nexmark-models

Conversation

@apilloud
Copy link
Member

Some of the Nexmark model tests don't produce any output at the current number of events. This change ensures every test produces some output. It also changes the Query 6 model to match the Query 6 implementation, but it still doesn't match the benchmark specification.


Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand:
    • What the pull request does
    • Why it does it
    • How it does it
    • Why this approach
  • Each commit in the pull request should have a meaningful subject line and body.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.

@apilloud
Copy link
Member Author

R: @kennknowles

@apilloud
Copy link
Member Author

apilloud commented Mar 8, 2018

Ping @kennknowles

@kennknowles
Copy link
Member

LGTM

@kennknowles kennknowles merged commit b3468b6 into apache:master Mar 8, 2018
@apilloud apilloud deleted the nexmark-models branch March 8, 2018 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants