Skip to content

Modal Component: Adds Spec and Portal Component#78

Merged
Raalzz merged 8 commits intoantstackio:mainfrom
pruthvi2103:modal/component
Aug 30, 2022
Merged

Modal Component: Adds Spec and Portal Component#78
Raalzz merged 8 commits intoantstackio:mainfrom
pruthvi2103:modal/component

Conversation

@pruthvi2103
Copy link
Copy Markdown
Contributor

@pruthvi2103 pruthvi2103 commented Aug 29, 2022

Description

Adds Portal Component

Motivation and Context

It creates a dialogue and is headless

How Has This Been Tested?

Tested in local

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@pruthvi2103
Create modal.mdx
fe6113c
@pruthvi2103
Squashed commit of the following:
5d46ac2 
commit fb57a63
Author: Saurabh Sutar <81956858+saurabhsutar192@users.noreply.github.com>
Date:   Fri Aug 12 14:13:36 2022 +0530

    HOV-16 | Divider component (antstackio#53)

    * divider component v1 created

    * typos fixed

    * mdx changes

    * divider default color changed

    * mdx changes

    * comments resolved

commit 2f5f842
Author: Pruthvi Shetty <pruthvishetty5656@gmail.com>
Date:   Fri Aug 12 14:10:43 2022 +0530

    Adds git playbook + adds steps for forking in contribution (antstackio#57)

commit fcc1d6a
Author: Pruthvi Shetty <pruthvishetty5656@gmail.com>
Date:   Fri Aug 12 14:09:52 2022 +0530

    move react to peerDep (antstackio#55)
@pruthvi2103
Merge remote-tracking branch 'upstream/main'
1b68153
@pruthvi2103
Merge remote-tracking branch 'upstream/main'
5ffcd92
@pruthvi2103
Merge branch 'main' into modal/spec
a98b120
@pruthvi2103
Update modal.mdx
266c0d8
@pruthvi2103
adds hooks for modal useBodyScroll and useClickOutside
df87737
@pruthvi2103
Adds React Portal Component
8b5407b
@pruthvi2103 pruthvi2103 added documentation Improvements or additions to documentation enhancement New feature or request labels Aug 29, 2022
@pruthvi2103 pruthvi2103 added this to the v0.1.8-alpha milestone Aug 29, 2022
@pruthvi2103 pruthvi2103 requested a review from Raalzz August 29, 2022 19:13
@pruthvi2103 pruthvi2103 self-assigned this Aug 29, 2022
@netlify
Copy link
Copy Markdown

netlify bot commented Aug 29, 2022 •
edited
Loading

✅ Deploy Preview for hover-design ready!

Name Link
🔨 Latest commit 8b5407b
🔍 Latest deploy log https://app.netlify.com/sites/hover-design/deploys/630d0fe9e44e910008035c4e
😎 Deploy Preview https://deploy-preview-78--hover-design.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pruthvi2103
Copy link
Copy Markdown
Contributor Author

pruthvi2103 commented Aug 29, 2022

Note, merge #77 before this

Raalzz
Raalzz approved these changes Aug 30, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@Raalzz Raalzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Raalzz Raalzz merged commit e35f6fc into antstackio:main Aug 30, 2022
@Raalzz Raalzz mentioned this pull request Aug 30, 2022
Closed
@pruthvi2103 pruthvi2103 mentioned this pull request Sep 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Raalzz Raalzz Raalzz approved these changes

Assignees

@pruthvi2103 pruthvi2103

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Milestone

v0.1.8-alpha

Development

Successfully merging this pull request may close these issues.

2 participants

@pruthvi2103 @Raalzz