Skip to content

Adds git playbook + adds steps for forking in contribution#57

Merged
Raalzz merged 1 commit intomainfrom
chores/playbooks
Aug 12, 2022
Merged

Adds git playbook + adds steps for forking in contribution#57
Raalzz merged 1 commit intomainfrom
chores/playbooks

Conversation

@pruthvi2103
Copy link
Copy Markdown
Contributor

@pruthvi2103 pruthvi2103 commented Aug 11, 2022

Description

Adds a git playbook for documenting our processes

Motivation and Context

To help people know what to do in situations and make them learn the best practices

How Has This Been Tested?

Tested in local dev

Screenshots (if appropriate):

Types of changes

  • Documentation

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

closes #56

@pruthvi2103 pruthvi2103 added the documentation Improvements or additions to documentation label Aug 11, 2022
@pruthvi2103 pruthvi2103 added this to the v0.1.7-alpha milestone Aug 11, 2022
@pruthvi2103 pruthvi2103 requested a review from Raalzz August 11, 2022 10:49
@pruthvi2103 pruthvi2103 self-assigned this Aug 11, 2022
@netlify
Copy link
Copy Markdown

netlify bot commented Aug 11, 2022 •
edited
Loading

✅ Deploy Preview for hover-design ready!

Name Link
🔨 Latest commit 38e4703
🔍 Latest deploy log https://app.netlify.com/sites/hover-design/deploys/62f4dec598fc4a0008ee11bf
😎 Deploy Preview https://deploy-preview-57--hover-design.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pruthvi2103 pruthvi2103 removed this from the v0.1.7-alpha milestone Aug 11, 2022
Raalzz
Raalzz approved these changes Aug 12, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@Raalzz Raalzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Raalzz Raalzz merged commit 2f5f842 into main Aug 12, 2022
@Raalzz Raalzz deleted the chores/playbooks branch August 12, 2022 08:40
pruthvi2103 added a commit to pruthvi2103/hover-design that referenced this pull request Aug 13, 2022
@pruthvi2103
Squashed commit of the following:
5d46ac2 
commit fb57a63
Author: Saurabh Sutar <81956858+saurabhsutar192@users.noreply.github.com>
Date:   Fri Aug 12 14:13:36 2022 +0530

    HOV-16 | Divider component (antstackio#53)

    * divider component v1 created

    * typos fixed

    * mdx changes

    * divider default color changed

    * mdx changes

    * comments resolved

commit 2f5f842
Author: Pruthvi Shetty <pruthvishetty5656@gmail.com>
Date:   Fri Aug 12 14:10:43 2022 +0530

    Adds git playbook + adds steps for forking in contribution (antstackio#57)

commit fcc1d6a
Author: Pruthvi Shetty <pruthvishetty5656@gmail.com>
Date:   Fri Aug 12 14:09:52 2022 +0530

    move react to peerDep (antstackio#55)
Raalzz added a commit that referenced this pull request Aug 19, 2022
@pruthvi2103 @Raalzz
Adds Accordion (#58)
a65da7f 
* Adds basic Accordion

* Squashed commit of the following:

commit fb57a63
Author: Saurabh Sutar <81956858+saurabhsutar192@users.noreply.github.com>
Date:   Fri Aug 12 14:13:36 2022 +0530

    HOV-16 | Divider component (#53)

    * divider component v1 created

    * typos fixed

    * mdx changes

    * divider default color changed

    * mdx changes

    * comments resolved

commit 2f5f842
Author: Pruthvi Shetty <pruthvishetty5656@gmail.com>
Date:   Fri Aug 12 14:10:43 2022 +0530

    Adds git playbook + adds steps for forking in contribution (#57)

commit fcc1d6a
Author: Pruthvi Shetty <pruthvishetty5656@gmail.com>
Date:   Fri Aug 12 14:09:52 2022 +0530

    move react to peerDep (#55)

* adds Accordion and other needed components

* Adds Accordion Docs

TODO

- Add refs to all components
- Add more examples in Docs

* remove accordion from examples

* remove accordion from index

* Adds Accordion docs

* Adds Forward Ref to all Accordion components

* fix ref type issue

* Update accordion.types.ts

* Update Accordion.tsx

* removes stray 0

* changes icon

* Update docs/docs/components/accordion.mdx

Co-authored-by: Raalzz <30571073+Raalzz@users.noreply.github.com>
Raalzz pushed a commit that referenced this pull request Aug 30, 2022
@pruthvi2103
Adds useClickOutside and useBodyScroll Hooks (#77)
dba349d 
* Squashed commit of the following:

commit fb57a63
Author: Saurabh Sutar <81956858+saurabhsutar192@users.noreply.github.com>
Date:   Fri Aug 12 14:13:36 2022 +0530

    HOV-16 | Divider component (#53)

    * divider component v1 created

    * typos fixed

    * mdx changes

    * divider default color changed

    * mdx changes

    * comments resolved

commit 2f5f842
Author: Pruthvi Shetty <pruthvishetty5656@gmail.com>
Date:   Fri Aug 12 14:10:43 2022 +0530

    Adds git playbook + adds steps for forking in contribution (#57)

commit fcc1d6a
Author: Pruthvi Shetty <pruthvishetty5656@gmail.com>
Date:   Fri Aug 12 14:09:52 2022 +0530

    move react to peerDep (#55)

* adds hooks for modal useBodyScroll and useClickOutside
Raalzz pushed a commit that referenced this pull request Aug 30, 2022
@pruthvi2103
Modal Component: Adds Spec and Portal Component (#78)
e35f6fc 
* Create modal.mdx

* Squashed commit of the following:

commit fb57a63
Author: Saurabh Sutar <81956858+saurabhsutar192@users.noreply.github.com>
Date:   Fri Aug 12 14:13:36 2022 +0530

    HOV-16 | Divider component (#53)

    * divider component v1 created

    * typos fixed

    * mdx changes

    * divider default color changed

    * mdx changes

    * comments resolved

commit 2f5f842
Author: Pruthvi Shetty <pruthvishetty5656@gmail.com>
Date:   Fri Aug 12 14:10:43 2022 +0530

    Adds git playbook + adds steps for forking in contribution (#57)

commit fcc1d6a
Author: Pruthvi Shetty <pruthvishetty5656@gmail.com>
Date:   Fri Aug 12 14:09:52 2022 +0530

    move react to peerDep (#55)

* Update modal.mdx

* adds hooks for modal useBodyScroll and useClickOutside

* Adds React Portal Component
Raalzz pushed a commit that referenced this pull request Sep 2, 2022
@pruthvi2103
Adds Modal component (#82)
c50e538 
* Squashed commit of the following:

commit fb57a63
Author: Saurabh Sutar <81956858+saurabhsutar192@users.noreply.github.com>
Date:   Fri Aug 12 14:13:36 2022 +0530

    HOV-16 | Divider component (#53)

    * divider component v1 created

    * typos fixed

    * mdx changes

    * divider default color changed

    * mdx changes

    * comments resolved

commit 2f5f842
Author: Pruthvi Shetty <pruthvishetty5656@gmail.com>
Date:   Fri Aug 12 14:10:43 2022 +0530

    Adds git playbook + adds steps for forking in contribution (#57)

commit fcc1d6a
Author: Pruthvi Shetty <pruthvishetty5656@gmail.com>
Date:   Fri Aug 12 14:09:52 2022 +0530

    move react to peerDep (#55)

* Adds Modal Code and docs

* add more details to modal
pruthvi2103 added a commit that referenced this pull request Sep 2, 2022
@pruthvi2103
Adds Dialog Component (#84)
4afd642 
* Squashed commit of the following:

commit fb57a63
Author: Saurabh Sutar <81956858+saurabhsutar192@users.noreply.github.com>
Date:   Fri Aug 12 14:13:36 2022 +0530

    HOV-16 | Divider component (#53)

    * divider component v1 created

    * typos fixed

    * mdx changes

    * divider default color changed

    * mdx changes

    * comments resolved

commit 2f5f842
Author: Pruthvi Shetty <pruthvishetty5656@gmail.com>
Date:   Fri Aug 12 14:10:43 2022 +0530

    Adds git playbook + adds steps for forking in contribution (#57)

commit fcc1d6a
Author: Pruthvi Shetty <pruthvishetty5656@gmail.com>
Date:   Fri Aug 12 14:09:52 2022 +0530

    move react to peerDep (#55)

* Adds Modal Code and docs

* adds dialog element

* fix docs
Raalzz pushed a commit that referenced this pull request Sep 14, 2022
@pruthvi2103
Fix accordion docs (#101)
d7b50cd 
* Squashed commit of the following:

commit fb57a63
Author: Saurabh Sutar <81956858+saurabhsutar192@users.noreply.github.com>
Date:   Fri Aug 12 14:13:36 2022 +0530

    HOV-16 | Divider component (#53)

    * divider component v1 created

    * typos fixed

    * mdx changes

    * divider default color changed

    * mdx changes

    * comments resolved

commit 2f5f842
Author: Pruthvi Shetty <pruthvishetty5656@gmail.com>
Date:   Fri Aug 12 14:10:43 2022 +0530

    Adds git playbook + adds steps for forking in contribution (#57)

commit fcc1d6a
Author: Pruthvi Shetty <pruthvishetty5656@gmail.com>
Date:   Fri Aug 12 14:09:52 2022 +0530

    move react to peerDep (#55)

* Update accordion.mdx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Raalzz Raalzz Raalzz approved these changes

Assignees

@pruthvi2103 pruthvi2103

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Clearity about the fork process

2 participants

@pruthvi2103 @Raalzz