Skip to content

HOV-45 | Fixes Icon component to have lesser base values #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
saurabhsutar192 merged 1 commit into from
Sep 20, 2022
Merged

HOV-45 | Fixes Icon component to have lesser base values #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 2 additions & 20 deletions lib/src/components/Icon/Icon.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,29 +4,11 @@ import { IIconProps } from "./icon.type";
const Icon: ForwardRefRenderFunction<SVGSVGElement, IIconProps> = ({
children,
xmlns = "http://www.w3.org/2000/svg",
width = "24",
height = "24",
viewBox = "0 0 24 24",
strokeWidth = "2",
stroke = "currentColor",
fill = "none",
strokeLinecap = "round",
strokeLinejoin = "round",

...nativeProps
}) => {
return (
<svg
xmlns={xmlns}
width={width}
height={height}
viewBox={viewBox}
strokeWidth={strokeWidth}
stroke={stroke}
fill={fill}
strokeLinecap={strokeLinecap}
strokeLinejoin={strokeLinejoin}
{...nativeProps}
>
<svg xmlns={xmlns} {...nativeProps}>
{children}
</svg>
);
Expand Down
12 changes: 11 additions & 1 deletion lib/src/components/_internal/Icons/ArrowDown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,17 @@ import { IIconProps } from "src/components/Icon/icon.type";

export const ArrowDown: FC<IIconProps> = (props) => {
return (
<Icon {...props}>
<Icon
width="24"
height="24"
viewBox="0 0 24 24"
strokeWidth="2"
stroke="currentColor"
fill="none"
strokeLinecap="round"
strokeLinejoin="round"
{...props}
>
<path stroke="none" d="M0 0h24v24H0z" fill="none"></path>
<line x1={12} y1={5} x2={12} y2={19}></line>
<line x1={18} y1={13} x2={12} y2={19}></line>
Expand Down
12 changes: 11 additions & 1 deletion lib/src/components/_internal/Icons/CheckIcon.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,17 @@ import { IIconProps } from "src/components/Icon/icon.type";

const CheckIcon: React.FC<IIconProps> = (props) => {
return (
<Icon viewBox="0 0 12 10" {...props}>
<Icon
width="24"
height="24"
strokeWidth="2"
stroke="currentColor"
fill="none"
strokeLinecap="round"
strokeLinejoin="round"
viewBox="0 0 12 10"
{...props}
>
<path
fill="currentColor"
stroke="none"
Expand Down
12 changes: 11 additions & 1 deletion lib/src/components/_internal/Icons/Chevron.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,17 @@ import { IIconProps } from "src/components/Icon/icon.type";

const ChevronIcon: React.FC<IIconProps> = (props) => {
return (
<Icon {...props}>
<Icon
width="24"
height="24"
viewBox="0 0 24 24"
strokeWidth="2"
stroke="currentColor"
fill="none"
strokeLinecap="round"
strokeLinejoin="round"
{...props}
>
<path stroke="none" d="M0 0h24v24H0z" fill="none"></path>
<polyline points="6 9 12 15 18 9"></polyline>
</Icon>
Expand Down
12 changes: 11 additions & 1 deletion lib/src/components/_internal/Icons/Clear.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,17 @@ import { IIconProps } from "src/components/Icon/icon.type";

export const Clear: FC<IIconProps> = (props) => {
return (
<Icon {...props}>
<Icon
width="24"
height="24"
viewBox="0 0 24 24"
strokeWidth="2"
stroke="currentColor"
fill="none"
strokeLinecap="round"
strokeLinejoin="round"
{...props}
>
<path stroke="none" d="M0 0h24v24H0z" fill="none"></path>
<circle cx={12} cy={12} r={9}></circle>
<path d="M10 10l4 4m0 -4l-4 4"></path>
Expand Down
12 changes: 11 additions & 1 deletion lib/src/components/_internal/Icons/Close.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,17 @@ import { IIconProps } from "../../../components/Icon/icon.type";

const CloseIcon: React.FC<IIconProps> = (props) => {
return (
<Icon {...props}>
<Icon
width="24"
height="24"
viewBox="0 0 24 24"
strokeWidth="2"
stroke="currentColor"
fill="none"
strokeLinecap="round"
strokeLinejoin="round"
{...props}
>
<path stroke="none" d="M0 0h24v24H0z" fill="none"></path>
<line x1="18" y1="6" x2="6" y2="18"></line>
<line x1="6" y1="6" x2="18" y2="18"></line>
Expand Down
12 changes: 11 additions & 1 deletion lib/src/components/_internal/Icons/DashIcon.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,17 @@ import { IIconProps } from "src/components/Icon/icon.type";

const DashIcon: React.FC<IIconProps> = (props) => {
return (
<Icon viewBox="0 0 32 6" {...props}>
<Icon
width="24"
height="24"
strokeWidth="2"
stroke="currentColor"
fill="none"
strokeLinecap="round"
strokeLinejoin="round"
viewBox="0 0 32 6"
{...props}
>
<rect width="32" height="6" fill="currentColor" rx="3" />
</Icon>
);
Expand Down
6 changes: 4 additions & 2 deletions lib/src/components/_internal/Icons/SvgDot.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
import { Icon } from "src/components/Icon";

const SvgDot = () => {
return (
<svg viewBox="0 0 6 6">
<Icon viewBox="0 0 6 6">
<circle fill="currentColor" cx="3" cy="3" r="3"></circle>
</svg>
</Icon>
);
};

Expand Down