Skip to content

HOV-45 | Fixes Icon component to have lesser base values#121

Merged
saurabhsutar192 merged 1 commit intoantstackio:mainfrom
pruthvi2103:HOV-45-icon-component-has-some-pre-defined-props-that-causes-some-issues
Sep 20, 2022
Merged

HOV-45 | Fixes Icon component to have lesser base values#121
saurabhsutar192 merged 1 commit intoantstackio:mainfrom
pruthvi2103:HOV-45-icon-component-has-some-pre-defined-props-that-causes-some-issues

Conversation

@pruthvi2103
Copy link
Copy Markdown
Contributor

Description

Icon component was highly opnionated, stripped some of the props down so that it was more usable

Motivation and Context

make Icon more usable

How Has This Been Tested?

tested in dev

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

closes #113

@pruthvi2103 pruthvi2103 added bug Something isn't working enhancement New feature or request labels Sep 20, 2022
@pruthvi2103 pruthvi2103 added this to the v0.1.10-alpha milestone Sep 20, 2022
@pruthvi2103 pruthvi2103 self-assigned this Sep 20, 2022
@netlify
Copy link
Copy Markdown

netlify bot commented Sep 20, 2022

Deploy Preview for hover-design canceled.

Name Link
🔨 Latest commit b933f75
🔍 Latest deploy log https://app.netlify.com/sites/hover-design/deploys/632966ee5ce90d000910484c

@saurabhsutar192
Copy link
Copy Markdown
Contributor

LGTM!

@saurabhsutar192 saurabhsutar192 merged commit bcf7eb6 into antstackio:main Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HOV-45 | Icon Component

2 participants