This repository was archived by the owner on May 29, 2019. It is now read-only.
fix(tooltip): memory leak on show/hide#2919
Closed
chrisirhc wants to merge 2 commits intoangular-ui:masterfrom
Closed
fix(tooltip): memory leak on show/hide#2919chrisirhc wants to merge 2 commits intoangular-ui:masterfrom
chrisirhc wants to merge 2 commits intoangular-ui:masterfrom
Conversation
tt_ scope variables are now in the ttScope which is specific to each tooltip directive (multiple tooltip directives can now run on the same element). This allows tooltips to be used alongside any directive that may or may not require different scope types. Closes angular-ui#1269 Fixes angular-ui#2320 Fixes angular-ui#2203
Create a new child scope and retain a reference to it so that it can be destroyed when the tooltip DOM is removed. Fixes angular-ui#2709
This was referenced Nov 2, 2014
OronNadiv
pushed a commit
to lanetix/bootstrap
that referenced
this pull request
Nov 18, 2014
Create a new child scope and retain a reference to it so that it can be destroyed when the tooltip DOM is removed. Fixes angular-ui#2709 Closes angular-ui#2919
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that this requires #2918 (the first commit in this PR).
Create a new child scope and retain a reference to it so that it can
be destroyed when the tooltip DOM is removed.
Fixes #2709