This repository was archived by the owner on May 29, 2019. It is now read-only.
fix scope leak in tooltip#2710
Closed
bespokebob wants to merge 1 commit intoangular-ui:masterfrom
bespokebob:master
Closed
fix scope leak in tooltip#2710bespokebob wants to merge 1 commit intoangular-ui:masterfrom bespokebob:master
bespokebob wants to merge 1 commit intoangular-ui:masterfrom
bespokebob:master
Conversation
Contributor
|
Thank you for this PR! However, I believe it's safer to create a new scope and retain a reference to it than to query the scope from the DOM. Since I'm making changes to the scopes for tooltips right now, I decided to create another PR (#2919) to resolve this leak. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2709