Update to v1.3.1#326
Merged
dcolleoni merged 1 commit intoExternalStakeholderPostProd4from Jun 23, 2023
Merged
Conversation
dcolleoni
approved these changes
Jun 23, 2023
dcolleoni
pushed a commit
that referenced
this pull request
Jun 23, 2023
* Log an Error for Invalid AY Types (#316) * Log an error for invalid AY types * Undo some changes in Importers * Undo * Feedback * Implement feedback * Optimize * Introduce Locked In CDR and Partner Rating for Technical Margin (#323) * First commit * Implement GetLockedNonPerformanceRiskRate * Improve and fix tests * Sketch ImportStorage Getter and add new CDR amount type * Implement GetAmountTypeDescendants in ImportStorage * Add EstimateType to the Identity of ValidAmountType scope * Add TM EstimateType and adjust TechnicalMargin scope * CDR Applicabilities should also apply for new CDR AmountType * Add TM EstimateType in Dimensions.csv * Feedback * Properly populate the locked-in dictionaries * Adjust the ParameterReportsQueries for locked-in Partner Rating and CreditDefaultRates * Feedback * Slicing in ParameterReports * Fix tests * All tests green * ParameterReports adjustments * Undo ParameterReports changes * Cleanup * Feedback: Refactor GetNonPerformanceRiskRate * Feedback * Revert EstimateType TM related changes * Adjust Dimensions.csv * Feedback * Filter out CDRI from Locked and Current BestEstimate in ReportScopes * Exclude CDR from BeAmountTypes in TechnicalMargin scope * Adapt BM for IfrsVariableTest * Adapt BM for ReportVariableTest * Fix PracticalCase-CompareReinsuranceTest * Fix diffs in ReportVariable BMs * Revert changes in ReportVariableBenchmarks_2020_12_CH__Contractual * Feedback in BM_CH_2020_12_MTUP10pct_BE * Feedback in README * Undo change in BM_CH_2020_12_MTUP10pct_BE * No need to compute and store CDRI for LIC * Adjust ParameterReports * Redo BMs for IfrsVariablesTest * Cleanup * Remove EstimateType TM from Consts * Feedback * Navigation MD in ImportScopeCalculation notebooks * Optimize GetNonPerformanceRiskRate * Feedback * Update to v1.3.1 (#326) Replace v1.3.0 with v1.3.1
nnikolopoulos
added a commit
that referenced
this pull request
Jun 27, 2023
* Develop (with removed Arithmetic) to Main (#63) * base code * correct broken links * fixed Opening re-import * Rename "PvBase" to "PresentValue" (#32) * include new default spaces * reorder global metadata using alphabetical order * Break utils nb (#33) * working on reports doc * metadata * break down utils * remove preview * update references to utils * fix image paths * reset doc around reports * fixing test + a ton of metadata * Cleanup redundant comments and import /Tests/TestHelper in SpecificationsFinancialPerformance * Move Export.ipynb inside the Export folder, fix import /Export/Export statement and comments cleanup in Utils/Extensions.ipynb * Empty commit to refresh the meta-data * Remove all *.orig files Co-authored-by: nnikolopoulos <nnikolopoulos@systemorph.com> * Including FX positions to FP scope * FP specification nb - add FX aoc step * Rename calculation type with estimate type (#34) * Replace CalculationType with EstimateType * Correct estimateType capitalization error in Test/SpecificationsImportCashflows.ipynb * Clean up notebooks spaces * Empty commit to refresh the meta-data * Cleanup comments in Import/ImportStorage.ipynb * Fix capitalization in Importers & ImportStorage NB * Fix column order in csv * Add blank cell DataNodeParameters link * new data node factory * metadata * metadata x2 * metadata x3 * implement feedback * split directories * fix tests + add readme + seperate overview nb * include changes on factory * adapt to the split * update packages and fix csm with bm * approaching * better * implement feedback * final feedback * fix * const version ce * Update links (#51) * working on links * read me * remove redundant code * clean up * AocConfiguration ImportFormat * remove reference to init from Overview * removal arithmetics * Simple value test data (#54) * Adding data files * Fix input * Fix input * change to importers test * Fix to sign * Int convention * reset consts * implement feedback part 1 * Overview texts (#53) * Overview (Template), revised text * Reports of template with small adjustments * Overview IFRS17, some adjustments * finalized + hot fixes * ReportGridOptions * final fixes and feedback implementations Co-authored-by: Sara Busato <sbusato@systemorph.com> Co-authored-by: sbusato <103484221+sbusato@users.noreply.github.com> Co-authored-by: nnikolopoulos <114566025+nnikolopoulos@users.noreply.github.com> Co-authored-by: nnikolopoulos <nnikolopoulos@systemorph.com> Co-authored-by: Andrea Muolo <amuolo@systemorph.com> Co-authored-by: amuolo <and.muolo@gmail.com> Co-authored-by: Daniel Trzesniak <dtrzesniak@systemorph.com> Co-authored-by: UMueller1 <108468853+UMueller1@users.noreply.github.com> * Dev to main (#66) * base code * correct broken links * fixed Opening re-import * Rename "PvBase" to "PresentValue" (#32) * include new default spaces * reorder global metadata using alphabetical order * Break utils nb (#33) * working on reports doc * metadata * break down utils * remove preview * update references to utils * fix image paths * reset doc around reports * fixing test + a ton of metadata * Cleanup redundant comments and import /Tests/TestHelper in SpecificationsFinancialPerformance * Move Export.ipynb inside the Export folder, fix import /Export/Export statement and comments cleanup in Utils/Extensions.ipynb * Empty commit to refresh the meta-data * Remove all *.orig files Co-authored-by: nnikolopoulos <nnikolopoulos@systemorph.com> * Including FX positions to FP scope * FP specification nb - add FX aoc step * Rename calculation type with estimate type (#34) * Replace CalculationType with EstimateType * Correct estimateType capitalization error in Test/SpecificationsImportCashflows.ipynb * Clean up notebooks spaces * Empty commit to refresh the meta-data * Cleanup comments in Import/ImportStorage.ipynb * Fix capitalization in Importers & ImportStorage NB * Fix column order in csv * Add blank cell DataNodeParameters link * new data node factory * metadata * metadata x2 * metadata x3 * implement feedback * split directories * fix tests + add readme + seperate overview nb * include changes on factory * adapt to the split * update packages and fix csm with bm * approaching * better * implement feedback * final feedback * fix * const version ce * Update links (#51) * working on links * read me * remove redundant code * clean up * AocConfiguration ImportFormat * remove reference to init from Overview * removal arithmetics * Simple value test data (#54) * Adding data files * Fix input * Fix input * change to importers test * Fix to sign * Int convention * reset consts * implement feedback part 1 * Overview texts (#53) * Overview (Template), revised text * Reports of template with small adjustments * Overview IFRS17, some adjustments * finalized + hot fixes * ReportGridOptions * final fixes and feedback implementations * Interactive reports (#58) * Ifrs17ReportScopes * wip * latest * add other reports * start with pv * filter does not work * clean up * clean up reports * clean up * typo * move it ce * remove partition set * adjust reporting * test readme with relative path for image * back to absolute path - bug in the portal - * wip * settle with identities * some more docs * adding rn and period selector * New format design in importers (#62) * Define new ImportFormats * Apply import w format in DN, DNS, DP, CF * Apply import w format in A, SV and O * Correct Import statements * Replace abs link with var link * Adjust naming convention * Adjust new import format in full-template * Package update (#65) * update packages * add anchors Co-authored-by: Sara Busato <sbusato@systemorph.com> Co-authored-by: sbusato <103484221+sbusato@users.noreply.github.com> Co-authored-by: nnikolopoulos <114566025+nnikolopoulos@users.noreply.github.com> Co-authored-by: nnikolopoulos <nnikolopoulos@systemorph.com> Co-authored-by: Andrea Muolo <amuolo@systemorph.com> Co-authored-by: amuolo <and.muolo@gmail.com> Co-authored-by: Daniel Trzesniak <dtrzesniak@systemorph.com> Co-authored-by: UMueller1 <108468853+UMueller1@users.noreply.github.com> * Update issue templates (#69) * Dev to main (#84) * base code * correct broken links * fixed Opening re-import * Rename "PvBase" to "PresentValue" (#32) * include new default spaces * reorder global metadata using alphabetical order * Break utils nb (#33) * working on reports doc * metadata * break down utils * remove preview * update references to utils * fix image paths * reset doc around reports * fixing test + a ton of metadata * Cleanup redundant comments and import /Tests/TestHelper in SpecificationsFinancialPerformance * Move Export.ipynb inside the Export folder, fix import /Export/Export statement and comments cleanup in Utils/Extensions.ipynb * Empty commit to refresh the meta-data * Remove all *.orig files Co-authored-by: nnikolopoulos <nnikolopoulos@systemorph.com> * Including FX positions to FP scope * FP specification nb - add FX aoc step * Rename calculation type with estimate type (#34) * Replace CalculationType with EstimateType * Correct estimateType capitalization error in Test/SpecificationsImportCashflows.ipynb * Clean up notebooks spaces * Empty commit to refresh the meta-data * Cleanup comments in Import/ImportStorage.ipynb * Fix capitalization in Importers & ImportStorage NB * Fix column order in csv * Add blank cell DataNodeParameters link * new data node factory * metadata * metadata x2 * metadata x3 * implement feedback * split directories * fix tests + add readme + seperate overview nb * include changes on factory * adapt to the split * still not working properly * code cleanup * new file creation * update packages and fix csm with bm * approaching * better * testing ifrsvariables * implement feedback * final feedback * fix * const version ce * testing IfrsVariables calculations * new partition added * implementing new test * test cleaned * Update links (#51) * working on links * read me * remove redundant code * clean up * AocConfiguration ImportFormat * remove reference to init from Overview * removal arithmetics * testing queries * Simple value test data (#54) * Adding data files * Fix input * Fix input * change to importers test * Fix to sign * Int convention * reset consts * implement feedback part 1 * Overview texts (#53) * Overview (Template), revised text * Reports of template with small adjustments * Overview IFRS17, some adjustments * finalized + hot fixes * ReportGridOptions * checking multiple import of the same scenario * final fixes and feedback implementations * dynamic problems solved * fixing aoctype for scenario * Interactive reports (#58) * Ifrs17ReportScopes * wip * latest * add other reports * start with pv * filter does not work * clean up * clean up reports * clean up * typo * move it ce * remove partition set * adjust reporting * test readme with relative path for image * back to absolute path - bug in the portal - * wip * settle with identities * some more docs * adding rn and period selector * test for actualsr * code cleanup * New format design in importers (#62) * Define new ImportFormats * Apply import w format in DN, DNS, DP, CF * Apply import w format in A, SV and O * Correct Import statements * Replace abs link with var link * Adjust naming convention * Adjust new import format in full-template * forward * Package update (#65) * update packages * add anchors * cleanups * Fixing AA and OA opening and benchmark simple importer (#57) * Fixing input data * Workaround for bm generation * Fixed GetSign * Inputs * Fixed Importers * add some doc * fixed CU * Dirty fix on signs * undo CU sign * wip * Fix signs * Init * fix * fix * exclude simple value from test * some partial fix * Full fix * much better * implemented * Aggregate by in report variable (#67) * included back AggregateBy * included Currency column in ReportVariable benchmarks * Clean up doc (#71) * remove spec tests * read me and big picture * help review * code of conduct. Readme. Remove Spec tests * env for go live * rename of directories in file * overview template * improve template readme * calculation engine and reports in template * more on ifrs17ce * NB titles * clean up display order * improve validation * fix links * fix link * Close import template * additions to report guide * solve conflicts * implement feedback * cleanups * cleanups x2 * fixes needed after merge * all tests are green * implement feedback * Doc cleanup2 (#76) * forbiddenSlices and chose init or db connection * clean ups * small letters to capital * complete sentence about filters * implement all feedbacks * packages + withGridOption + await HierarchyCache init (#83) Co-authored-by: Sara Busato <sbusato@systemorph.com> Co-authored-by: sbusato <103484221+sbusato@users.noreply.github.com> Co-authored-by: nnikolopoulos <114566025+nnikolopoulos@users.noreply.github.com> Co-authored-by: nnikolopoulos <nnikolopoulos@systemorph.com> Co-authored-by: Andrea Muolo <amuolo@systemorph.com> Co-authored-by: amuolo <and.muolo@gmail.com> Co-authored-by: Danilo Calderini <dcalderini@systemorph.com> Co-authored-by: Daniel Trzesniak <dtrzesniak@systemorph.com> Co-authored-by: UMueller1 <108468853+UMueller1@users.noreply.github.com> * Dev to main (#86) * base code * correct broken links * fixed Opening re-import * Rename "PvBase" to "PresentValue" (#32) * include new default spaces * reorder global metadata using alphabetical order * Break utils nb (#33) * working on reports doc * metadata * break down utils * remove preview * update references to utils * fix image paths * reset doc around reports * fixing test + a ton of metadata * Cleanup redundant comments and import /Tests/TestHelper in SpecificationsFinancialPerformance * Move Export.ipynb inside the Export folder, fix import /Export/Export statement and comments cleanup in Utils/Extensions.ipynb * Empty commit to refresh the meta-data * Remove all *.orig files Co-authored-by: nnikolopoulos <nnikolopoulos@systemorph.com> * Including FX positions to FP scope * FP specification nb - add FX aoc step * Rename calculation type with estimate type (#34) * Replace CalculationType with EstimateType * Correct estimateType capitalization error in Test/SpecificationsImportCashflows.ipynb * Clean up notebooks spaces * Empty commit to refresh the meta-data * Cleanup comments in Import/ImportStorage.ipynb * Fix capitalization in Importers & ImportStorage NB * Fix column order in csv * Add blank cell DataNodeParameters link * new data node factory * metadata * metadata x2 * metadata x3 * implement feedback * split directories * fix tests + add readme + seperate overview nb * include changes on factory * adapt to the split * still not working properly * code cleanup * new file creation * update packages and fix csm with bm * approaching * better * testing ifrsvariables * implement feedback * final feedback * fix * const version ce * testing IfrsVariables calculations * new partition added * implementing new test * test cleaned * Update links (#51) * working on links * read me * remove redundant code * clean up * AocConfiguration ImportFormat * remove reference to init from Overview * removal arithmetics * testing queries * Simple value test data (#54) * Adding data files * Fix input * Fix input * change to importers test * Fix to sign * Int convention * reset consts * implement feedback part 1 * Overview texts (#53) * Overview (Template), revised text * Reports of template with small adjustments * Overview IFRS17, some adjustments * finalized + hot fixes * ReportGridOptions * checking multiple import of the same scenario * final fixes and feedback implementations * dynamic problems solved * fixing aoctype for scenario * Interactive reports (#58) * Ifrs17ReportScopes * wip * latest * add other reports * start with pv * filter does not work * clean up * clean up reports * clean up * typo * move it ce * remove partition set * adjust reporting * test readme with relative path for image * back to absolute path - bug in the portal - * wip * settle with identities * some more docs * adding rn and period selector * test for actualsr * code cleanup * New format design in importers (#62) * Define new ImportFormats * Apply import w format in DN, DNS, DP, CF * Apply import w format in A, SV and O * Correct Import statements * Replace abs link with var link * Adjust naming convention * Adjust new import format in full-template * forward * Package update (#65) * update packages * add anchors * cleanups * Fixing AA and OA opening and benchmark simple importer (#57) * Fixing input data * Workaround for bm generation * Fixed GetSign * Inputs * Fixed Importers * add some doc * fixed CU * Dirty fix on signs * undo CU sign * wip * Fix signs * Init * fix * fix * exclude simple value from test * some partial fix * Full fix * much better * implemented * Aggregate by in report variable (#67) * included back AggregateBy * included Currency column in ReportVariable benchmarks * Clean up doc (#71) * remove spec tests * read me and big picture * help review * code of conduct. Readme. Remove Spec tests * env for go live * rename of directories in file * overview template * improve template readme * calculation engine and reports in template * more on ifrs17ce * NB titles * clean up display order * improve validation * fix links * fix link * Close import template * additions to report guide * solve conflicts * implement feedback * cleanups * cleanups x2 * fixes needed after merge * all tests are green * implement feedback * Doc cleanup2 (#76) * forbiddenSlices and chose init or db connection * clean ups * small letters to capital * complete sentence about filters * implement all feedbacks * packages + withGridOption + await HierarchyCache init (#83) * Change in ReportMutableScopes NB * Change in ReportMutableScopes NB (#85) Co-authored-by: Davide Colleoni <dcolleoni@systemorph.com> Co-authored-by: Davide Colleoni <103409906+dcolleoni@users.noreply.github.com> Co-authored-by: Sara Busato <sbusato@systemorph.com> Co-authored-by: sbusato <103484221+sbusato@users.noreply.github.com> Co-authored-by: Andrea Muolo <amuolo@systemorph.com> Co-authored-by: amuolo <and.muolo@gmail.com> Co-authored-by: Danilo Calderini <dcalderini@systemorph.com> Co-authored-by: Daniel Trzesniak <dtrzesniak@systemorph.com> Co-authored-by: UMueller1 <108468853+UMueller1@users.noreply.github.com> * delete full template dir * remove images * Openings: remove reimport duplicates (#150) * fixed ImportStorage queries for openings * clean up * debug import scopes * enhance technical margin test - reproduce the bug - * fix and increase test coverage * clean up * typos * update to v1.1.1 * Log an Error for Invalid AY Types (#316) * Log an error for invalid AY types * Undo some changes in Importers * Undo * Feedback * Implement feedback * Optimize * Introduce Locked In CDR and Partner Rating for Technical Margin (#323) * First commit * Implement GetLockedNonPerformanceRiskRate * Improve and fix tests * Sketch ImportStorage Getter and add new CDR amount type * Implement GetAmountTypeDescendants in ImportStorage * Add EstimateType to the Identity of ValidAmountType scope * Add TM EstimateType and adjust TechnicalMargin scope * CDR Applicabilities should also apply for new CDR AmountType * Add TM EstimateType in Dimensions.csv * Feedback * Properly populate the locked-in dictionaries * Adjust the ParameterReportsQueries for locked-in Partner Rating and CreditDefaultRates * Feedback * Slicing in ParameterReports * Fix tests * All tests green * ParameterReports adjustments * Undo ParameterReports changes * Cleanup * Feedback: Refactor GetNonPerformanceRiskRate * Feedback * Revert EstimateType TM related changes * Adjust Dimensions.csv * Feedback * Filter out CDRI from Locked and Current BestEstimate in ReportScopes * Exclude CDR from BeAmountTypes in TechnicalMargin scope * Adapt BM for IfrsVariableTest * Adapt BM for ReportVariableTest * Fix PracticalCase-CompareReinsuranceTest * Fix diffs in ReportVariable BMs * Revert changes in ReportVariableBenchmarks_2020_12_CH__Contractual * Feedback in BM_CH_2020_12_MTUP10pct_BE * Feedback in README * Undo change in BM_CH_2020_12_MTUP10pct_BE * No need to compute and store CDRI for LIC * Adjust ParameterReports * Redo BMs for IfrsVariablesTest * Cleanup * Remove EstimateType TM from Consts * Feedback * Navigation MD in ImportScopeCalculation notebooks * Optimize GetNonPerformanceRiskRate * Feedback * Update to v1.3.1 (#326) Replace v1.3.0 with v1.3.1 * Fix Lambda in LoadCurrentParameterAsync * Md RAM augment --------- Co-authored-by: Davide Colleoni <103409906+dcolleoni@users.noreply.github.com> Co-authored-by: Sara Busato <sbusato@systemorph.com> Co-authored-by: sbusato <103484221+sbusato@users.noreply.github.com> Co-authored-by: Andrea Muolo <amuolo@systemorph.com> Co-authored-by: amuolo <and.muolo@gmail.com> Co-authored-by: Daniel Trzesniak <dtrzesniak@systemorph.com> Co-authored-by: UMueller1 <108468853+UMueller1@users.noreply.github.com> Co-authored-by: Danilo Calderini <dcalderini@systemorph.com> Co-authored-by: Davide Colleoni <dcolleoni@systemorph.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace v1.3.0 with v1.3.1