Merged
Conversation
* Log an error for invalid AY types * Undo some changes in Importers * Undo * Feedback * Implement feedback * Optimize
* First commit * Implement GetLockedNonPerformanceRiskRate * Improve and fix tests * Sketch ImportStorage Getter and add new CDR amount type * Implement GetAmountTypeDescendants in ImportStorage * Add EstimateType to the Identity of ValidAmountType scope * Add TM EstimateType and adjust TechnicalMargin scope * CDR Applicabilities should also apply for new CDR AmountType * Add TM EstimateType in Dimensions.csv * Feedback * Properly populate the locked-in dictionaries * Adjust the ParameterReportsQueries for locked-in Partner Rating and CreditDefaultRates * Feedback * Slicing in ParameterReports * Fix tests * All tests green * ParameterReports adjustments * Undo ParameterReports changes * Cleanup * Feedback: Refactor GetNonPerformanceRiskRate * Feedback * Revert EstimateType TM related changes * Adjust Dimensions.csv * Feedback * Filter out CDRI from Locked and Current BestEstimate in ReportScopes * Exclude CDR from BeAmountTypes in TechnicalMargin scope * Adapt BM for IfrsVariableTest * Adapt BM for ReportVariableTest * Fix PracticalCase-CompareReinsuranceTest * Fix diffs in ReportVariable BMs * Revert changes in ReportVariableBenchmarks_2020_12_CH__Contractual * Feedback in BM_CH_2020_12_MTUP10pct_BE * Feedback in README * Undo change in BM_CH_2020_12_MTUP10pct_BE * No need to compute and store CDRI for LIC * Adjust ParameterReports * Redo BMs for IfrsVariablesTest * Cleanup * Remove EstimateType TM from Consts * Feedback * Navigation MD in ImportScopeCalculation notebooks * Optimize GetNonPerformanceRiskRate * Feedback
nnikolopoulos
added
enhancement
Replace v1.3.0 with v1.3.1
dcolleoni
approved these changes
Jun 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
External stakeholder feature branch including features outlined in issues:
To be merged to main.