Skip to content

Hot fix loreco#226

Merged
dcolleoni merged 21 commits intodevelopfrom
hotFix-Loreco
Mar 2, 2023
Merged

Hot fix loreco#226
dcolleoni merged 21 commits intodevelopfrom
hotFix-Loreco

Conversation

@dcolleoni
Copy link
Copy Markdown
Contributor

No description provided.

dcolleoni and others added 21 commits November 2, 2022 13:40
* base code

* correct broken links

* fixed Opening re-import

* Rename "PvBase" to "PresentValue" (#32)

* include new default spaces

* reorder global metadata using alphabetical order

* Break utils nb (#33)

* working on reports doc

* metadata

* break down utils

* remove preview

* update references to utils

* fix image paths

* reset doc around reports

* fixing test + a ton of metadata

* Cleanup redundant comments and import /Tests/TestHelper in SpecificationsFinancialPerformance

* Move Export.ipynb inside the Export folder, fix import /Export/Export statement and comments cleanup in Utils/Extensions.ipynb

* Empty commit to refresh the meta-data

* Remove all *.orig files

Co-authored-by: nnikolopoulos <nnikolopoulos@systemorph.com>

* Including FX positions to FP scope

* FP specification nb - add FX aoc step

* Rename calculation type with estimate type (#34)

* Replace CalculationType with EstimateType

* Correct estimateType capitalization error in Test/SpecificationsImportCashflows.ipynb

* Clean up notebooks spaces

* Empty commit to refresh the meta-data

* Cleanup comments in Import/ImportStorage.ipynb

* Fix capitalization in Importers & ImportStorage NB

* Fix column order in csv

* Add blank cell DataNodeParameters link

* new data node factory

* metadata

* metadata x2

* metadata x3

* implement feedback

* split directories

* fix tests + add readme + seperate overview nb

* include changes on factory

* adapt to the split

* update packages and fix csm with bm

* approaching

* better

* implement feedback

* final feedback

* fix

* const version ce

* Update links (#51)

* working on links

* read me

* remove redundant code

* clean up

* AocConfiguration ImportFormat

* remove reference to init from Overview

* removal arithmetics

* Simple value test data (#54)

* Adding data files

* Fix input

* Fix input

* change to importers test

* Fix to sign

* Int convention

* reset consts

* implement feedback part 1

* Overview texts (#53)

* Overview (Template), revised text

* Reports of template with small adjustments

* Overview IFRS17, some adjustments

* finalized + hot fixes

* ReportGridOptions

* final fixes and feedback implementations

Co-authored-by: Sara Busato <sbusato@systemorph.com>
Co-authored-by: sbusato <103484221+sbusato@users.noreply.github.com>
Co-authored-by: nnikolopoulos <114566025+nnikolopoulos@users.noreply.github.com>
Co-authored-by: nnikolopoulos <nnikolopoulos@systemorph.com>
Co-authored-by: Andrea Muolo <amuolo@systemorph.com>
Co-authored-by: amuolo <and.muolo@gmail.com>
Co-authored-by: Daniel Trzesniak <dtrzesniak@systemorph.com>
Co-authored-by: UMueller1 <108468853+UMueller1@users.noreply.github.com>
* base code

* correct broken links

* fixed Opening re-import

* Rename "PvBase" to "PresentValue" (#32)

* include new default spaces

* reorder global metadata using alphabetical order

* Break utils nb (#33)

* working on reports doc

* metadata

* break down utils

* remove preview

* update references to utils

* fix image paths

* reset doc around reports

* fixing test + a ton of metadata

* Cleanup redundant comments and import /Tests/TestHelper in SpecificationsFinancialPerformance

* Move Export.ipynb inside the Export folder, fix import /Export/Export statement and comments cleanup in Utils/Extensions.ipynb

* Empty commit to refresh the meta-data

* Remove all *.orig files

Co-authored-by: nnikolopoulos <nnikolopoulos@systemorph.com>

* Including FX positions to FP scope

* FP specification nb - add FX aoc step

* Rename calculation type with estimate type (#34)

* Replace CalculationType with EstimateType

* Correct estimateType capitalization error in Test/SpecificationsImportCashflows.ipynb

* Clean up notebooks spaces

* Empty commit to refresh the meta-data

* Cleanup comments in Import/ImportStorage.ipynb

* Fix capitalization in Importers & ImportStorage NB

* Fix column order in csv

* Add blank cell DataNodeParameters link

* new data node factory

* metadata

* metadata x2

* metadata x3

* implement feedback

* split directories

* fix tests + add readme + seperate overview nb

* include changes on factory

* adapt to the split

* update packages and fix csm with bm

* approaching

* better

* implement feedback

* final feedback

* fix

* const version ce

* Update links (#51)

* working on links

* read me

* remove redundant code

* clean up

* AocConfiguration ImportFormat

* remove reference to init from Overview

* removal arithmetics

* Simple value test data (#54)

* Adding data files

* Fix input

* Fix input

* change to importers test

* Fix to sign

* Int convention

* reset consts

* implement feedback part 1

* Overview texts (#53)

* Overview (Template), revised text

* Reports of template with small adjustments

* Overview IFRS17, some adjustments

* finalized + hot fixes

* ReportGridOptions

* final fixes and feedback implementations

* Interactive reports (#58)

* Ifrs17ReportScopes

* wip

* latest

* add other reports

* start with pv

* filter does not work

* clean up

* clean up reports

* clean up

* typo

* move it ce

* remove partition set

* adjust reporting

* test readme with relative path for image

* back to absolute path - bug in the portal -

* wip

* settle with identities

* some more docs

* adding rn and period selector

* New format design in importers (#62)

* Define new ImportFormats

* Apply import w format in DN, DNS, DP, CF

* Apply import w format in A, SV and O

* Correct Import statements

* Replace abs link with var link

* Adjust naming convention

* Adjust new import format in full-template

* Package update (#65)

* update packages

* add anchors

Co-authored-by: Sara Busato <sbusato@systemorph.com>
Co-authored-by: sbusato <103484221+sbusato@users.noreply.github.com>
Co-authored-by: nnikolopoulos <114566025+nnikolopoulos@users.noreply.github.com>
Co-authored-by: nnikolopoulos <nnikolopoulos@systemorph.com>
Co-authored-by: Andrea Muolo <amuolo@systemorph.com>
Co-authored-by: amuolo <and.muolo@gmail.com>
Co-authored-by: Daniel Trzesniak <dtrzesniak@systemorph.com>
Co-authored-by: UMueller1 <108468853+UMueller1@users.noreply.github.com>
* base code

* correct broken links

* fixed Opening re-import

* Rename "PvBase" to "PresentValue" (#32)

* include new default spaces

* reorder global metadata using alphabetical order

* Break utils nb (#33)

* working on reports doc

* metadata

* break down utils

* remove preview

* update references to utils

* fix image paths

* reset doc around reports

* fixing test + a ton of metadata

* Cleanup redundant comments and import /Tests/TestHelper in SpecificationsFinancialPerformance

* Move Export.ipynb inside the Export folder, fix import /Export/Export statement and comments cleanup in Utils/Extensions.ipynb

* Empty commit to refresh the meta-data

* Remove all *.orig files

Co-authored-by: nnikolopoulos <nnikolopoulos@systemorph.com>

* Including FX positions to FP scope

* FP specification nb - add FX aoc step

* Rename calculation type with estimate type (#34)

* Replace CalculationType with EstimateType

* Correct estimateType capitalization error in Test/SpecificationsImportCashflows.ipynb

* Clean up notebooks spaces

* Empty commit to refresh the meta-data

* Cleanup comments in Import/ImportStorage.ipynb

* Fix capitalization in Importers & ImportStorage NB

* Fix column order in csv

* Add blank cell DataNodeParameters link

* new data node factory

* metadata

* metadata x2

* metadata x3

* implement feedback

* split directories

* fix tests + add readme + seperate overview nb

* include changes on factory

* adapt to the split

* still not working properly

* code cleanup

* new file creation

* update packages and fix csm with bm

* approaching

* better

* testing ifrsvariables

* implement feedback

* final feedback

* fix

* const version ce

* testing IfrsVariables calculations

* new partition added

* implementing new test

* test cleaned

* Update links (#51)

* working on links

* read me

* remove redundant code

* clean up

* AocConfiguration ImportFormat

* remove reference to init from Overview

* removal arithmetics

* testing queries

* Simple value test data (#54)

* Adding data files

* Fix input

* Fix input

* change to importers test

* Fix to sign

* Int convention

* reset consts

* implement feedback part 1

* Overview texts (#53)

* Overview (Template), revised text

* Reports of template with small adjustments

* Overview IFRS17, some adjustments

* finalized + hot fixes

* ReportGridOptions

* checking multiple import of the same scenario

* final fixes and feedback implementations

* dynamic problems solved

* fixing aoctype for scenario

* Interactive reports (#58)

* Ifrs17ReportScopes

* wip

* latest

* add other reports

* start with pv

* filter does not work

* clean up

* clean up reports

* clean up

* typo

* move it ce

* remove partition set

* adjust reporting

* test readme with relative path for image

* back to absolute path - bug in the portal -

* wip

* settle with identities

* some more docs

* adding rn and period selector

* test for actualsr

* code cleanup

* New format design in importers (#62)

* Define new ImportFormats

* Apply import w format in DN, DNS, DP, CF

* Apply import w format in A, SV and O

* Correct Import statements

* Replace abs link with var link

* Adjust naming convention

* Adjust new import format in full-template

* forward

* Package update (#65)

* update packages

* add anchors

* cleanups

* Fixing AA and OA opening and benchmark simple importer (#57)

* Fixing input data

* Workaround for bm generation

* Fixed GetSign

* Inputs

* Fixed Importers

* add some doc

* fixed CU

* Dirty fix on signs

* undo CU sign

* wip

* Fix signs

* Init

* fix

* fix

* exclude simple value from test

* some partial fix

* Full fix

* much better

* implemented

* Aggregate by in report variable (#67)

* included back AggregateBy

* included Currency column in ReportVariable benchmarks

* Clean up doc (#71)

* remove spec tests

* read me and big picture

* help review

* code of conduct. Readme. Remove Spec tests

* env for go live

* rename of directories in file

* overview template

* improve template readme

* calculation engine and reports in template

* more on ifrs17ce

* NB titles

* clean up display order

* improve validation

* fix links

* fix link

* Close import template

* additions to report guide

* solve conflicts

* implement feedback

* cleanups

* cleanups x2

* fixes needed after merge

* all tests are green

* implement feedback

* Doc cleanup2 (#76)

* forbiddenSlices and chose init or db connection

* clean ups

* small letters to capital

* complete sentence about filters

* implement all feedbacks

* packages + withGridOption + await HierarchyCache init (#83)

Co-authored-by: Sara Busato <sbusato@systemorph.com>
Co-authored-by: sbusato <103484221+sbusato@users.noreply.github.com>
Co-authored-by: nnikolopoulos <114566025+nnikolopoulos@users.noreply.github.com>
Co-authored-by: nnikolopoulos <nnikolopoulos@systemorph.com>
Co-authored-by: Andrea Muolo <amuolo@systemorph.com>
Co-authored-by: amuolo <and.muolo@gmail.com>
Co-authored-by: Danilo Calderini <dcalderini@systemorph.com>
Co-authored-by: Daniel Trzesniak <dtrzesniak@systemorph.com>
Co-authored-by: UMueller1 <108468853+UMueller1@users.noreply.github.com>
* base code

* correct broken links

* fixed Opening re-import

* Rename "PvBase" to "PresentValue" (#32)

* include new default spaces

* reorder global metadata using alphabetical order

* Break utils nb (#33)

* working on reports doc

* metadata

* break down utils

* remove preview

* update references to utils

* fix image paths

* reset doc around reports

* fixing test + a ton of metadata

* Cleanup redundant comments and import /Tests/TestHelper in SpecificationsFinancialPerformance

* Move Export.ipynb inside the Export folder, fix import /Export/Export statement and comments cleanup in Utils/Extensions.ipynb

* Empty commit to refresh the meta-data

* Remove all *.orig files

Co-authored-by: nnikolopoulos <nnikolopoulos@systemorph.com>

* Including FX positions to FP scope

* FP specification nb - add FX aoc step

* Rename calculation type with estimate type (#34)

* Replace CalculationType with EstimateType

* Correct estimateType capitalization error in Test/SpecificationsImportCashflows.ipynb

* Clean up notebooks spaces

* Empty commit to refresh the meta-data

* Cleanup comments in Import/ImportStorage.ipynb

* Fix capitalization in Importers & ImportStorage NB

* Fix column order in csv

* Add blank cell DataNodeParameters link

* new data node factory

* metadata

* metadata x2

* metadata x3

* implement feedback

* split directories

* fix tests + add readme + seperate overview nb

* include changes on factory

* adapt to the split

* still not working properly

* code cleanup

* new file creation

* update packages and fix csm with bm

* approaching

* better

* testing ifrsvariables

* implement feedback

* final feedback

* fix

* const version ce

* testing IfrsVariables calculations

* new partition added

* implementing new test

* test cleaned

* Update links (#51)

* working on links

* read me

* remove redundant code

* clean up

* AocConfiguration ImportFormat

* remove reference to init from Overview

* removal arithmetics

* testing queries

* Simple value test data (#54)

* Adding data files

* Fix input

* Fix input

* change to importers test

* Fix to sign

* Int convention

* reset consts

* implement feedback part 1

* Overview texts (#53)

* Overview (Template), revised text

* Reports of template with small adjustments

* Overview IFRS17, some adjustments

* finalized + hot fixes

* ReportGridOptions

* checking multiple import of the same scenario

* final fixes and feedback implementations

* dynamic problems solved

* fixing aoctype for scenario

* Interactive reports (#58)

* Ifrs17ReportScopes

* wip

* latest

* add other reports

* start with pv

* filter does not work

* clean up

* clean up reports

* clean up

* typo

* move it ce

* remove partition set

* adjust reporting

* test readme with relative path for image

* back to absolute path - bug in the portal -

* wip

* settle with identities

* some more docs

* adding rn and period selector

* test for actualsr

* code cleanup

* New format design in importers (#62)

* Define new ImportFormats

* Apply import w format in DN, DNS, DP, CF

* Apply import w format in A, SV and O

* Correct Import statements

* Replace abs link with var link

* Adjust naming convention

* Adjust new import format in full-template

* forward

* Package update (#65)

* update packages

* add anchors

* cleanups

* Fixing AA and OA opening and benchmark simple importer (#57)

* Fixing input data

* Workaround for bm generation

* Fixed GetSign

* Inputs

* Fixed Importers

* add some doc

* fixed CU

* Dirty fix on signs

* undo CU sign

* wip

* Fix signs

* Init

* fix

* fix

* exclude simple value from test

* some partial fix

* Full fix

* much better

* implemented

* Aggregate by in report variable (#67)

* included back AggregateBy

* included Currency column in ReportVariable benchmarks

* Clean up doc (#71)

* remove spec tests

* read me and big picture

* help review

* code of conduct. Readme. Remove Spec tests

* env for go live

* rename of directories in file

* overview template

* improve template readme

* calculation engine and reports in template

* more on ifrs17ce

* NB titles

* clean up display order

* improve validation

* fix links

* fix link

* Close import template

* additions to report guide

* solve conflicts

* implement feedback

* cleanups

* cleanups x2

* fixes needed after merge

* all tests are green

* implement feedback

* Doc cleanup2 (#76)

* forbiddenSlices and chose init or db connection

* clean ups

* small letters to capital

* complete sentence about filters

* implement all feedbacks

* packages + withGridOption + await HierarchyCache init (#83)

* Change in ReportMutableScopes NB

* Change in ReportMutableScopes NB (#85)

Co-authored-by: Davide Colleoni <dcolleoni@systemorph.com>
Co-authored-by: Davide Colleoni <103409906+dcolleoni@users.noreply.github.com>
Co-authored-by: Sara Busato <sbusato@systemorph.com>
Co-authored-by: sbusato <103484221+sbusato@users.noreply.github.com>
Co-authored-by: Andrea Muolo <amuolo@systemorph.com>
Co-authored-by: amuolo <and.muolo@gmail.com>
Co-authored-by: Danilo Calderini <dcalderini@systemorph.com>
Co-authored-by: Daniel Trzesniak <dtrzesniak@systemorph.com>
Co-authored-by: UMueller1 <108468853+UMueller1@users.noreply.github.com>
# Conflicts:
#	LICENSE
#	README.md
#	full-ifrs17-template/LICENSE
#	ifrs17-template/LICENSE
#	ifrs17/CalculationEngine.ipynb
#	ifrs17/Constants/Consts.ipynb
#	ifrs17/Constants/Enums.ipynb
#	ifrs17/Constants/Validations.ipynb
#	ifrs17/DataModel/DataStructure.ipynb
#	ifrs17/Export/ExportConfiguration.ipynb
#	ifrs17/Import/ImportScopeCalculation.ipynb
#	ifrs17/Import/ImportStorage.ipynb
#	ifrs17/Import/Importers.ipynb
#	ifrs17/OverviewCalculationEngine.ipynb
#	ifrs17/README.md
#	ifrs17/Report/ReportConfigurationAndUtils.ipynb
#	ifrs17/Report/ReportMutableScopes.ipynb
#	ifrs17/Report/ReportScopes.ipynb
#	ifrs17/Report/ReportStorage.ipynb
#	ifrs17/Test/AocConfigurationTest.ipynb
#	ifrs17/Test/QueriesTest.ipynb
#	ifrs17/Test/Tests.ipynb
#	ifrs17/Utils/ApplicationMessage.ipynb
#	ifrs17/Utils/EqualityComparers.ipynb
#	ifrs17/Utils/Extensions.ipynb
#	ifrs17/Utils/ImportCalculationMethods.ipynb
#	ifrs17/Utils/Queries.ipynb
#	ifrs17/Utils/TestHelper.ipynb
* fixed ImportStorage queries for openings

* clean up
@dcolleoni dcolleoni added the bug Something isn't working label Feb 24, 2023
@dcolleoni dcolleoni added this to the v1.1.x milestone Feb 24, 2023
@dcolleoni dcolleoni self-assigned this Feb 24, 2023
Copy link
Copy Markdown
Contributor

@nnikolopoulos nnikolopoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@dcolleoni dcolleoni merged commit d467aaa into develop Mar 2, 2023
@dcolleoni dcolleoni deleted the hotFix-Loreco branch March 2, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants